From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F4AC4361B for ; Tue, 15 Dec 2020 11:16:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D4E322255 for ; Tue, 15 Dec 2020 11:16:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D4E322255 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Date:In-reply-to:Message-ID:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wql0lohdkr9of7OljTTG6SNcwMCezwr9Q6/w18zClAM=; b=QduBTT1+sd0LNFMximN60HAOM 7SRsr+F1cP/FRWH/gM16mMxm/St1fjpbZNAQAhZGLr+KrxxKvY614LlEzbhDiKaXNxol2OZAX3zob Z/sOvjMdIGtoFxvyM77/9/SbBtEJXVFiloLPUUfA23k5mFiKFt3j7z4rYrSWfb1EmCE+SUi7vLxvx 8hFOacEAK6i5bPGnjYso2qq/pX6uf8JU9lFJayTkkjoaSUVDrH2QBZdvCxKTCBNRe2aCuGU/0IBzT wwrI17vJ5RF90dZz7Va8AJSnPsZtC1QfZWusQusrRDCihKmaBHkn8nVQCBp9IhsJII0uwHr0xwkvq uZkZGLrGw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp8IL-000513-V8; Tue, 15 Dec 2020 11:15:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp8IJ-00050U-9z for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 11:15:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24E381FB; Tue, 15 Dec 2020 03:14:58 -0800 (PST) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A0273F66E; Tue, 15 Dec 2020 03:14:56 -0800 (PST) References: <20201109094121.29975-1-valentin.schneider@arm.com> <20201109094121.29975-4-valentin.schneider@arm.com> <20201215002134.GA182208@roeck-us.net> <38f8fbe9ceb7a0adb47e62d62260b297@kernel.org> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Marc Zyngier Subject: Re: [PATCH 3/5] irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq() Message-ID: In-reply-to: <38f8fbe9ceb7a0adb47e62d62260b297@kernel.org> Date: Tue, 15 Dec 2020 11:14:50 +0000 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_061503_417686_A06210A0 X-CRM114-Status: GOOD ( 21.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Lorenzo Pieralisi , Jason Cooper , Scott Branden , Ray Jui , Gregory Clement , linux-kernel@vger.kernel.org, Florian Fainelli , Guenter Roeck , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/12/20 10:19, Marc Zyngier wrote: > Hi Gunter, > > On 2020-12-15 00:21, Guenter Roeck wrote: >> On Mon, Nov 09, 2020 at 09:41:19AM +0000, Valentin Schneider wrote: >>> As done for the Arm GIC irqchips, move IPIs to >>> handle_percpu_devid_irq() as >>> handle_percpu_devid_fasteoi_ipi() isn't actually required. >>> >>> Signed-off-by: Valentin Schneider >> >> This patch results in boot failures (silent stall) for the qemu >> raspi2 emulation. Unfortunately it can not be reverted because >> handle_percpu_devid_fasteoi_ipi no longer exists in next-20201214, >> so I don't know if it is the only problem. > > This is odd. This works just fine for me on both the RPi2 and 3 > emulation, running a full Debian userspace. Could this be caused > by the version of QEMU you are using? Here's what I have: > > $ qemu-system-arm --version > QEMU emulator version 5.1.0 (Debian 1:5.1+dfsg-4+b1) > > Could you try the following hack and let me know if that helps? > Thanks for looking into this. It does look like I inverted the ordering of that mailbox write vs the handling of the IPI. I don't see how the IPI could mess with the mailbox (unless some creative use of irq_work / smp_call), but in any case having the write in irq_ack() as you've done below should restore said ordering. > Thanks, > > M. > > diff --git a/drivers/irqchip/irq-bcm2836.c > b/drivers/irqchip/irq-bcm2836.c > index 5f5eb8877c41..25c9a9c06e41 100644 > --- a/drivers/irqchip/irq-bcm2836.c > +++ b/drivers/irqchip/irq-bcm2836.c > @@ -167,7 +167,7 @@ static void bcm2836_arm_irqchip_handle_ipi(struct > irq_desc *desc) > chained_irq_exit(chip, desc); > } > > -static void bcm2836_arm_irqchip_ipi_eoi(struct irq_data *d) > +static void bcm2836_arm_irqchip_ipi_ack(struct irq_data *d) > { > int cpu = smp_processor_id(); > > @@ -195,7 +195,7 @@ static struct irq_chip bcm2836_arm_irqchip_ipi = { > .name = "IPI", > .irq_mask = bcm2836_arm_irqchip_dummy_op, > .irq_unmask = bcm2836_arm_irqchip_dummy_op, > - .irq_eoi = bcm2836_arm_irqchip_ipi_eoi, > + .irq_ack = bcm2836_arm_irqchip_ipi_ack, > .ipi_send_mask = bcm2836_arm_irqchip_ipi_send_mask, > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel