From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DBDC433DF for ; Tue, 14 Jul 2020 15:06:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A65FC20663 for ; Tue, 14 Jul 2020 15:06:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xAqAV/mZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A65FC20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GE7EvfRk5kzzSWGqAMAjQcI8aNTpWPL6WqicZBxHCZE=; b=xAqAV/mZisbEBW7vvF4pUCpDy tVFEilOFvuXiytDUfhvTDGLdOfqCi1Umj8Eq+sQMDAQnjY76gH7MDbTubnyUuOSOOnZ5iby19sSJR zP7x/dnVbKJWdhpuE/lkCbPFHCVdCzGQhpsptacJHz2mOYaKWKNndHKaR76XgzYTkrXkeaMA3DRXm UjO/cM247EsY2LwyoTu2TlfKEv095gKHQOGqRG3KgvyaKctCaLhMRmMpq74VXCZYI+f04i+YzUScv bveRmLSqbOk8Sgdb3I1Cy5aA5gM1PLAtTV8se0LLJsmUJo5TMxlrn1iV0uC2gc2L5XzRkgB83+BgC pBgc8RhIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMTq-0008Hb-7b; Tue, 14 Jul 2020 15:04:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvMTm-0008Gq-7b for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 15:04:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C93D430E; Tue, 14 Jul 2020 08:04:18 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E13C53F792; Tue, 14 Jul 2020 08:04:17 -0700 (PDT) References: <20200714124556.20294-1-sudeep.holla@arm.com> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Sudeep Holla Subject: Re: [PATCH] rtc: pl031: fix set_alarm by adding back call to alarm_irq_enable In-reply-to: <20200714124556.20294-1-sudeep.holla@arm.com> Date: Tue, 14 Jul 2020 16:04:08 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_110422_327951_75204988 X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alexandre Belloni , Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/07/20 13:45, Sudeep Holla wrote: > Commit c8ff5841a90b ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64") > seemed to have accidentally removed the call to pl031_alarm_irq_enable > from pl031_set_alarm while switching to 64-bit apis. > > Let us add back the same to get the set alarm functionality back. > > Fixes: c8ff5841a90b ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64") > Cc: Linus Walleij > Cc: Alexandre Belloni > Signed-off-by: Sudeep Holla Thanks for looking into this! CONFIG_TEST_SUSPEND with test_suspend=mem now behaves correctly (i.e. comes back out of suspend), and $ rtcwake -d /dev/rtc0 -s 2 -m no shows an increase in RTC interrupts (which remains at 0 before this patch). Tested-by: Valentin Schneider > --- > drivers/rtc/rtc-pl031.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c > index 40d7450a1ce4..c6b89273feba 100644 > --- a/drivers/rtc/rtc-pl031.c > +++ b/drivers/rtc/rtc-pl031.c > @@ -275,6 +275,7 @@ static int pl031_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) > struct pl031_local *ldata = dev_get_drvdata(dev); > > writel(rtc_tm_to_time64(&alarm->time), ldata->base + RTC_MR); > + pl031_alarm_irq_enable(dev, alarm->enabled); > > return 0; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel