From: avictor.za@gmail.com (Andrew Victor)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] AT91: at91sam9g10 chip identification changed
Date: Tue, 13 Apr 2010 09:42:55 +0200 [thread overview]
Message-ID: <l2ocd73a99e1004130042qfe9aba83l512a0fad50112d19@mail.gmail.com> (raw)
In-Reply-To: <1270115336-19488-1-git-send-email-nicolas.ferre@atmel.com>
hi Nicolas,
> A bit in the at91sam9g10 identification number changed between Engineering
> Sample and final product. This patch will identify both as being at91sam9g10.
> -#define ARCH_ID_AT91SAM9G10 ? ?0x819903a0
> +#define ARCH_ID_AT91SAM9G10 ? ?0x019903a0
> -#define cpu_is_at91sam9g10() ? (at91_cpu_identify() == ARCH_ID_AT91SAM9G10)
> +#define cpu_is_at91sam9g10() ? ((at91_cpu_identify() & ~AT91_CIDR_EXT) == ARCH_ID_AT91SAM9G10)
Wouldn't it be better to just mask out the AT91_CIDR_EXT bit in
at91_cpu_identify()?
That bit isn't really useful for "version" information.
We'd then just need to modify:
#define ARCH_ID_AT91SAM9G10 0x019903a0
#define ARCH_ID_AT91SAM9G45 0x019b05a0
#define ARCH_ID_AT91SAM9G45MRL 0x019b05a2 /* aka 9G45-ES2 &
non ES lots */
#define ARCH_ID_AT91SAM9G45ES 0x019b05a1 /* 9G45-ES
(Engineering Sample) */
(ie, drop bit AT91_CIDR_EXT)
Regards,
Andrew Victor
next prev parent reply other threads:[~2010-04-13 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 9:48 [PATCH] AT91: at91sam9g10 chip identification changed Nicolas Ferre
2010-04-12 18:44 ` Russell King - ARM Linux
2010-04-13 7:42 ` Andrew Victor [this message]
2010-04-14 8:14 ` Nicolas Ferre
2010-04-14 15:01 ` Andrew Victor
2010-04-14 15:40 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=l2ocd73a99e1004130042qfe9aba83l512a0fad50112d19@mail.gmail.com \
--to=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).