From mboxrd@z Thu Jan  1 00:00:00 1970
From: arve@android.com (=?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?=)
Date: Wed, 31 Mar 2010 14:21:16 -0700
Subject: [PATCH 1/4] arm: msm: gpio support
In-Reply-To: <1270044182.2025.0.camel@m0nster>
References: <1269990717-2969-1-git-send-email-dwalker@codeaurora.org>
	<0D753D10438DA54287A00B027084269763691C346E@AUSP01VMBX24.collaborationhost.net>
	<d6200be21003301814m538a5902s649415d6cc7ec8fa@mail.gmail.com>
	<1270044182.2025.0.camel@m0nster>
Message-ID: <l2ud6200be21003311421p8dc78179sf62b1d62d468528a@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

2010/3/31 Daniel Walker <dwalker@codeaurora.org>:
> On Tue, 2010-03-30 at 18:14 -0700, Arve Hj?nnev?g wrote:
>> On Tue, Mar 30, 2010 at 4:58 PM, H Hartley Sweeten
>> <hartleys@visionengravers.com> wrote:
>> > On Tuesday, March 30, 2010 4:12 PM, Daniel Walker wrote:
>> >> From: Daniel Walker <c_dwalke@quicinc.com>
>> ...
>> >> +
>> >> +static void msm_gpio_irq_ack(unsigned int irq)
>> >> +{
>> >> + ? ? unsigned long irq_flags;
>> >> + ? ? struct msm_gpio_chip *msm_chip = get_irq_chip_data(irq);
>> >> + ? ? unsigned b;
>> >> +
>> >> + ? ? spin_lock_irqsave(&msm_chip->lock, irq_flags);
>> >> +
>> >> + ? ? b = 1U << (irq - FIRST_GPIO_IRQ - msm_chip->chip.base);
>> >
>> > Urk... That's a bit confusing...
>> >
>> > You might want to make this a macro or an inline function with some kind
>> > of comment.
>> >
>>
>> On a related note, why did you inline msm_gpio_clear_detect_status? It
>> is used from two other functions.
>>
>
> You mean other places in the Android tree?

No, you copied it three times in this file.

-- 
Arve Hj?nnev?g