From: oliver@schinagl.nl (Olliver Schinagl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: sunxi: DT: Convert the DTs to use a header for the pinctrl nodes
Date: Mon, 5 Jan 2015 07:41:59 +0000 (UTC) [thread overview]
Message-ID: <loom.20150105T083747-798@post.gmane.org> (raw)
In-Reply-To: 1418767199-20957-4-git-send-email-maxime.ripard@free-electrons.com
Hey Maxime!
Maxime Ripard <maxime.ripard <at> free-electrons.com> writes:
>
> The pinctrl nodes require some extra opaque arguments for the pull up and
drive
> strength values.
>
> Introduce a new header file and convert the device trees to replace these
> opaque numbers by defines.
<snip>
>
> diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts
b/arch/arm/boot/dts/sun4i-a10-a1000.dts
> index 532ab3bd9735..b67e5be618cf 100644
> --- a/arch/arm/boot/dts/sun4i-a10-a1000.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-a1000.dts
> <at> <at> -52,6 +52,7 <at> <at>
> #include "sunxi-common-regulators.dtsi"
>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/sun4i-a10.h>
>
> / {
> model = "Mele A1000";
> <at> <at> -114,15 +115,15 <at> <at>
> emac_power_pin_a1000: emac_power_pin <at> 0 {
> allwinner,pins = "PH15";
> allwinner,function = "gpio_out";
> - allwinner,drive = <0>;
> - allwinner,pull = <0>;
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
May I query why you used Mega Ampere's for the drive strength? ;) I know
it's quite obvious it means mili-amps, but I recall reading that small
letters in defines is 'acceptable' in the case of mA, which is already used
in the dts files for the imx.
I doubt we will ever see MegaAmp in any dts ;) but technically not impossible.
Olliver
next prev parent reply other threads:[~2015-01-05 7:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 21:59 [PATCH 1/6] ARM: sunxi: DT: Convert to device tree includes Maxime Ripard
2014-12-16 21:59 ` [PATCH 2/6] ARM: sunxi: DT: convert DTs to use common GPIOs includes Maxime Ripard
2014-12-16 21:59 ` [PATCH 3/6] ARM: sunxi: DT: Convert the DTs to use a header for the DMA arguments Maxime Ripard
2014-12-16 21:59 ` [PATCH 4/6] ARM: sunxi: DT: Convert the DTs to use a header for the pinctrl nodes Maxime Ripard
2015-01-05 7:41 ` Olliver Schinagl [this message]
2014-12-16 21:59 ` [PATCH 5/6] ARM: sunxi: DT: Convert the DTs to use the GIC headers Maxime Ripard
2014-12-16 21:59 ` [PATCH 6/6] ARM: sunxi: DT: Convert the DTs to use the generic interrupt header Maxime Ripard
2014-12-17 7:32 ` [PATCH 1/6] ARM: sunxi: DT: Convert to device tree includes Arnd Bergmann
2014-12-17 21:33 ` Maxime Ripard
2014-12-17 22:33 ` Arnd Bergmann
2014-12-19 8:46 ` Maxime Ripard
2015-01-06 11:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20150105T083747-798@post.gmane.org \
--to=oliver@schinagl.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).