public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: enrico.scholz@sigma-chemnitz.de (Enrico Scholz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/mxs: support irqs triggered by both edges
Date: Mon, 12 Mar 2012 18:02:04 +0100	[thread overview]
Message-ID: <lyhaxt4usz.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <20120312163503.AEBC73E07B0@localhost> (Grant Likely's message of "Mon, 12 Mar 2012 10:35:03 -0600")

Grant Likely <grant.likely@secretlab.ca> writes:

>> iMX28 silicon does not support irqs triggered by both gpio edges. Patch
>> emulates this behavior by configuring such irqs as level triggered and
>> by switching polarity in the interrupt handler.
>
> That looks dodgy and hacky.  This will definitely miss interrupts if
> they come in too fast. 

Because patch calculates the trigger from the actual level, there should
not be missed more interrupts than with native edge-both support.

> I don't like this approach.  What do you need it for?

some drivers (e.g. gpio-keys, otg gpio-vbus, gpio-charger) are requesting
gpio based interrupts with IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING
flags.  It is not possible to use such drivers without having EDGE_BOTH
support.


Enrico

  reply	other threads:[~2012-03-12 17:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20 13:52 [PATCH] gpio/mxs: support irqs triggered by both edges Enrico Scholz
2012-03-12 16:35 ` Grant Likely
2012-03-12 17:02   ` Enrico Scholz [this message]
2012-03-12 17:17     ` Grant Likely
2012-03-12 17:38       ` Enrico Scholz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lyhaxt4usz.fsf@ensc-virt.intern.sigma-chemnitz.de \
    --to=enrico.scholz@sigma-chemnitz.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox