From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7386BC433E0 for ; Tue, 23 Feb 2021 05:18:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E34E964E31 for ; Tue, 23 Feb 2021 05:18:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E34E964E31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xmission.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID:In-Reply-To:Date: References:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V7hwMtOEIQnUg8Jk1Rd89nwKVg0s5cmKtp8gZ6z2yr8=; b=uv9s6Zs9O5nlspLlbHext21Zk E5E7QxqiglApbxNOL102aqrwIg5mL1QLavi5Z2drsh5IQaA7OYE+YVfLcPdNZZIZCdhKgjHZ3Nq8K WB5atx/QEwo6TWS2raAC4Z5Q3P5x7mOZlcPeUqNVC9fEzh8Y9YjKOmUooDj34KOH2mjizoosAMtIr MAtuLr0yjgFB0TD/gamUPEZtjwAE46DEHf7TgKrY1eHN7tM1rZMaMv58QChRkPXIyWv3N7jTVvnH3 N+NHJC9F3siNdeiZv3B7OCPS0XsxVoeRY35n0FSQP+VUeLBZY5hQXOuoScVF4cAy7JwnUB8fMf6+a a/3ce0kBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEQ4Y-0002tX-HG; Tue, 23 Feb 2021 05:17:22 +0000 Received: from out01.mta.xmission.com ([166.70.13.231]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEQ4V-0002rG-Ti; Tue, 23 Feb 2021 05:17:21 +0000 Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lEQ48-00ABIl-6P; Mon, 22 Feb 2021 22:16:56 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=fess.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lEQ47-003en1-Dn; Mon, 22 Feb 2021 22:16:55 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Will Deacon References: <20210219195142.13571-1-pasha.tatashin@soleen.com> <161399720788.2051103.17455817952511939013.b4-ty@kernel.org> Date: Mon, 22 Feb 2021 23:16:38 -0600 In-Reply-To: <161399720788.2051103.17455817952511939013.b4-ty@kernel.org> (Will Deacon's message of "Mon, 22 Feb 2021 14:29:01 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-XM-SPF: eid=1lEQ47-003en1-Dn; ; ; mid=; ; ; hst=in02.mta.xmission.com; ; ; ip=68.227.160.95; ; ; frm=ebiederm@xmission.com; ; ; spf=neutral X-XM-AID: U2FsdGVkX1/njm8oIeOFBiruLt6tVNkQHTfo43YCCvM= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v2] kexec: move machine_kexec_post_load() to public interface X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210223_001720_000310_1C57DA1A X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Tatashin , catalin.marinas@arm.com, kexec@lists.infradead.org, jmorris@namei.org, linux-kernel@vger.kernel.org, tyhicks@linux.microsoft.com, james.morse@arm.com, kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Will Deacon writes: > On Fri, 19 Feb 2021 14:51:42 -0500, Pavel Tatashin wrote: >> machine_kexec_post_load() is called after kexec load is finished. It must >> declared in public header not in kexec_internal.h >> >> Fixes the following compiler warning: >> >> arch/arm64/kernel/machine_kexec.c:62:5: warning: no previous prototype for >> function 'machine_kexec_post_load' [-Wmissing-prototypes] >> int machine_kexec_post_load(struct kimage *kimage) > > Applied to arm64 (for-next/fixes), thanks! > > [1/1] kexec: move machine_kexec_post_load() to public interface > https://git.kernel.org/arm64/c/2596b6ae412b As you have already applied this it seems a bit late, but I will mention that change could legitimately have the following tag. Fixes: de68e4daea90 ("kexec: add machine_kexec_post_load()") So far arm64 is the only implementation of that hook. Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel