From: martinwguy@gmail.com (Martin Guy)
To: linux-arm-kernel@lists.infradead.org
Subject: [spi-devel-general] [PATCH v4 1/2] spi: implemented driver for Cirrus EP93xx SPI controller
Date: Sun, 25 Apr 2010 10:38:32 +0100 [thread overview]
Message-ID: <m2l56d259a01004250238s99d6c869s1ee084b36f9736a0@mail.gmail.com> (raw)
In-Reply-To: <y2x56d259a01004250229he9cb2ee3pf69669c9226f80fb@mail.gmail.com>
Sorry about the incomplete message. Finger trouble.
On 4/25/10, Martin Guy <martinwguy@gmail.com> wrote:
...
> SFRMOUT will have gone high:
> if (espi->tx >0 && espi->tx < t->len
&& !(ep93xx_spi_read_u16(espi, SSPSR) & SSPSR_BSY)) {
> /* More to transmit but device has gone idle means that
> * SFRMOUT will have gone high */
> printk("ep93xx-spi: Underrun\n");
> }
I've also done a version that doesn't printk() in the middle of it,
which affects timing, but counts the underruns and reports at end of
transfer. The result is that every 512-byte block underruns at least
once, sometimes twice.
I'll run a few more tests, e.g. dropping the clock rate, but at this
point I'd be inclined to declare it impossible to keep SFRMOUT low
during a transfer, and just use the simple non-continuous code with a
comment at the top of the file that explains why you can't use SFRMOUT
as a chip select for devices that require CS to remain asserted for
the duration of a transfer.
M
next prev parent reply other threads:[~2010-04-25 9:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 15:11 [PATCH v4 0/2] spi: driver for Cirrus EP93xx SPI controller Mika Westerberg
2010-04-20 15:11 ` [PATCH v4 1/2] spi: implemented " Mika Westerberg
2010-04-20 17:24 ` H Hartley Sweeten
2010-04-21 7:16 ` Mika Westerberg
2010-04-21 16:47 ` H Hartley Sweeten
2010-04-21 16:54 ` Mika Westerberg
2010-04-22 2:47 ` H Hartley Sweeten
2010-04-22 5:53 ` Mika Westerberg
2010-04-22 14:11 ` Martin Guy
2010-04-22 14:28 ` Martin Guy
2010-04-22 17:39 ` H Hartley Sweeten
2010-04-22 20:19 ` Martin Guy
2010-04-20 22:16 ` H Hartley Sweeten
2010-04-20 23:54 ` Martin Guy
2010-04-21 0:11 ` H Hartley Sweeten
2010-04-21 0:43 ` [spi-devel-general] " H Hartley Sweeten
2010-04-21 1:10 ` Martin Guy
2010-04-21 1:52 ` H Hartley Sweeten
2010-04-21 7:00 ` Mika Westerberg
2010-04-21 10:46 ` Mika Westerberg
2010-04-21 18:00 ` H Hartley Sweeten
2010-04-22 5:45 ` Mika Westerberg
2010-04-22 21:29 ` Ryan Mallon
2010-04-22 17:55 ` Mika Westerberg
2010-04-22 20:43 ` H Hartley Sweeten
2010-04-23 5:20 ` Mika Westerberg
2010-04-23 17:24 ` H Hartley Sweeten
2010-04-23 23:01 ` [spi-devel-general] " H Hartley Sweeten
2010-04-25 9:29 ` Martin Guy
2010-04-25 9:38 ` Martin Guy [this message]
2010-04-25 20:25 ` H Hartley Sweeten
2010-04-26 10:02 ` Mika Westerberg
2010-04-26 16:54 ` H Hartley Sweeten
2010-04-26 10:09 ` Mika Westerberg
2010-04-26 14:35 ` Martin Guy
2010-04-26 17:05 ` H Hartley Sweeten
2010-04-29 18:30 ` Mika Westerberg
2010-04-21 6:37 ` Mika Westerberg
2010-04-21 17:08 ` H Hartley Sweeten
2010-04-24 18:14 ` Martin Guy
2010-04-25 19:55 ` H Hartley Sweeten
2010-04-26 10:34 ` Mika Westerberg
2010-04-26 12:58 ` Martin Guy
2010-04-20 15:11 ` [PATCH v4 2/2] ep93xx: SPI driver platform support code Mika Westerberg
2010-04-20 16:35 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2l56d259a01004250238s99d6c869s1ee084b36f9736a0@mail.gmail.com \
--to=martinwguy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).