From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] IXP4xx: Ensure index is positive
Date: Thu, 05 Nov 2009 14:04:59 +0100 [thread overview]
Message-ID: <m33a4t5dhg.fsf@intrepid.localdomain> (raw)
In-Reply-To: <4AF0A92C.6050400@gmail.com> (Roel Kluin's message of "Tue, 03 Nov 2009 23:05:32 +0100")
Roel Kluin <roel.kluin@gmail.com> writes:
> +++ b/arch/arm/mach-ixp4xx/common.c
> @@ -117,7 +117,7 @@ int gpio_to_irq(int gpio)
> }
> EXPORT_SYMBOL(gpio_to_irq);
>
> -int irq_to_gpio(int irq)
> +int irq_to_gpio(unsigned int irq)
> {
> int gpio = (irq < 32) ? irq2gpio[irq] : -EINVAL;
>
> diff --git a/arch/arm/mach-ixp4xx/include/mach/gpio.h b/arch/arm/mach-ixp4xx/include/mach/gpio.h
> index cd5aec2..a5f87de 100644
> --- a/arch/arm/mach-ixp4xx/include/mach/gpio.h
> +++ b/arch/arm/mach-ixp4xx/include/mach/gpio.h
> @@ -70,7 +70,7 @@ static inline void gpio_set_value(unsigned gpio, int value)
> #include <asm-generic/gpio.h> /* cansleep wrappers */
>
> extern int gpio_to_irq(int gpio);
> -extern int irq_to_gpio(int gpio);
> +extern int irq_to_gpio(unsigned int irq);
>
> #endif
>
> diff --git a/arch/arm/mach-ixp4xx/include/mach/npe.h b/arch/arm/mach-ixp4xx/include/mach/npe.h
> index 37d0511..e320db2 100644
> --- a/arch/arm/mach-ixp4xx/include/mach/npe.h
> +++ b/arch/arm/mach-ixp4xx/include/mach/npe.h
> @@ -33,7 +33,7 @@ int npe_send_message(struct npe *npe, const void *msg, const char *what);
> int npe_recv_message(struct npe *npe, void *msg, const char *what);
> int npe_send_recv_message(struct npe *npe, void *msg, const char *what);
> int npe_load_firmware(struct npe *npe, const char *name, struct device *dev);
> -struct npe *npe_request(int id);
> +struct npe *npe_request(unsigned id);
> void npe_release(struct npe *npe);
>
> #endif /* __IXP4XX_NPE_H */
> diff --git a/arch/arm/mach-ixp4xx/ixp4xx_npe.c b/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> index 47ac69c..e8bb257 100644
> --- a/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> +++ b/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> @@ -665,7 +665,7 @@ err:
> }
>
>
> -struct npe *npe_request(int id)
> +struct npe *npe_request(unsigned id)
It looks good, thanks a lot.
--
Krzysztof Halasa
prev parent reply other threads:[~2009-11-05 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 19:10 [PATCH] IXP4xx: Ensure index is positive Roel Kluin
2009-11-03 20:27 ` Karl Hiramoto
2009-11-03 21:23 ` Krzysztof Halasa
2009-11-03 22:05 ` Roel Kluin
2009-11-05 13:04 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33a4t5dhg.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox