From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ixp4xx: Declare MODULE_FIRMWARE usage
Date: Sat, 28 Jul 2012 13:12:37 +0200 [thread overview]
Message-ID: <m34nosi1ga.fsf@intrepid.localdomain> (raw)
In-Reply-To: <1343241186-103293-1-git-send-email-tim.gardner@canonical.com> (Tim Gardner's message of "Wed, 25 Jul 2012 12:33:06 -0600")
Tim Gardner <tim.gardner@canonical.com> writes:
> +++ b/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> @@ -116,7 +116,11 @@
> /* NPE mailbox_status value for reset */
> #define RESET_MBOX_STAT 0x0000F0F0
>
> -const char *npe_names[] = { "NPE-A", "NPE-B", "NPE-C" };
> +#define NPE_A_FIRMWARE "NPE-A"
> +#define NPE_B_FIRMWARE "NPE-B"
> +#define NPE_C_FIRMWARE "NPE-C"
> +
> +const char *npe_names[] = { NPE_A_FIRMWARE, NPE_B_FIRMWARE, NPE_C_FIRMWARE };
>
> #define print_npe(pri, npe, fmt, ...) \
> printk(pri "%s: " fmt, npe_name(npe), ## __VA_ARGS__)
> @@ -724,6 +728,9 @@ module_exit(npe_cleanup_module);
>
> MODULE_AUTHOR("Krzysztof Halasa");
> MODULE_LICENSE("GPL v2");
> +MODULE_FIRMWARE(NPE_A_FIRMWARE);
> +MODULE_FIRMWARE(NPE_B_FIRMWARE);
> +MODULE_FIRMWARE(NPE_C_FIRMWARE);
>
> EXPORT_SYMBOL(npe_names);
> EXPORT_SYMBOL(npe_running);
This looks like a good idea, thanks.
--
Krzysztof Halasa
prev parent reply other threads:[~2012-07-28 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 18:33 [PATCH] ixp4xx: Declare MODULE_FIRMWARE usage Tim Gardner
2012-07-28 11:12 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34nosi1ga.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox