public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: khalasa@piap.pl (Krzysztof Hałasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ixp4xx_eth: Setup coherent_dma_mask
Date: Wed, 05 Mar 2014 10:55:02 +0100	[thread overview]
Message-ID: <m38uspas21.fsf@t19.piap.pl> (raw)
In-Reply-To: <20140305094330.GU21483@n2100.arm.linux.org.uk> (Russell King's message of "Wed, 5 Mar 2014 09:43:30 +0000")

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

>> > +	err = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
>> > +	if (err < 0)
>> > +		goto err_free;
>> > +
>> 
>> Both David and the DMA API say 32 bits must be the default. OTOH there
>> is other code like this in the kernel, guess IXP4xx is not alone with
>> such constrains.
>
> If you have drivers missing this call, that's part of the problem:
>
> | For correct operation, you must interrogate the kernel in your device
> | probe routine to see if the DMA controller on the machine can properly
> | support the DMA addressing limitation your device has.

Well, we already know it can. Actually, the DMA controller is a part of
the CPU + RAM controller chip :-)

But I guess with this new wording it's something the drivers can use.
-- 
Krzysztof Halasa

Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

  reply	other threads:[~2014-03-05  9:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05  7:53 [PATCH 0/2]: ixp4xx: Fix 3.7 regression for IXP4xx ethernet driver Simon Kågström
2014-03-05  7:55 ` [PATCH 1/2] ARM: ixp4xx: Make dma_set_coherent_mask common, correct implementation Simon Kågström
2014-03-05  7:55 ` [PATCH 2/2] ixp4xx_eth: Setup coherent_dma_mask Simon Kågström
2014-03-05  9:21   ` Krzysztof Hałasa
2014-03-05  9:43     ` Russell King - ARM Linux
2014-03-05  9:55       ` Krzysztof Hałasa [this message]
2014-03-05 10:07         ` Simon Kågström
2014-03-05 10:12         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38uspas21.fsf@t19.piap.pl \
    --to=khalasa@piap.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox