From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC809C6FD1D for ; Tue, 21 Mar 2023 15:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5ZJDAbxkna18eBfvmF7ZQT07TyWknB09EQmFoI9i2Pg=; b=jdpX06LKGaK4IA U/QSaii5SC2XKXfRCixcMeO4QnD1psg5HdWk+LMGqKUM/JgXhxRmdNJ7r2vyBwIWBNZ1pOw8rO8eF Gxi+uWQd8WVI6YHFsRUmp8te5xAtWvE0QeyBiX2QqUw9uBYsISW6RWy0L0qidcwkqYnUUwcpktOGr jBt0YvrlWCN0vlaNsQQsSHINkJBZ7sE5YYjy9EMm/+QDg3vlWsJEaiYEaSTI0u8UAKBQeEZgznKNK J6lS5oGVj6WIl45vw4wVxEE6mw3on3bhBKds4b7t1nl0GFS824Oxor0JhCRIa6mKyojcwNPHXw8n/ Ok46GF+c9zMzpOJqZCcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pedTO-00CpQV-1C; Tue, 21 Mar 2023 15:00:26 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pedTH-00CpME-11 for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 15:00:20 +0000 Received: by mail-wm1-x330.google.com with SMTP id v4-20020a05600c470400b003ee4f06428fso106746wmo.4 for ; Tue, 21 Mar 2023 08:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679410815; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/SKvKGtYbJspT2KfSVVcegusA4FS/+In9jNUHnh2Smc=; b=P3/JN7QvITsVuX1klcHni87+mXKPlqijSK7TO1nWayAZJMFXHn9Hjo04TiOV8VGQhT e7Pw3rEQHMAKm08sMdm08V+95oFkwsyTVvsSwNKWaeN36I1asxgbX/vYeA2PwCUYcD01 FZjpaaIvzdqNUizGr6/58n9FqfXaUIeHfPUpaHRPFlg0CWhV3EV+P9l2JWcVU6AciEBm lU4Ml5bkcxBiKOqdor27Roo89Djcd5xi439uCbcd2RS3LjB5Lsyz3WSzQ4i5/G00NsaY ig/u9sSLGYsUjrtwXfqTkZfojJsPbP4pAkgAtANmXslT3CkJQPwwIqMnAxfeoDbjNer3 tqsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679410815; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/SKvKGtYbJspT2KfSVVcegusA4FS/+In9jNUHnh2Smc=; b=5eacbGg+Tc4Dl37nwx2amQW43fFNiA41JJrGwPz3YhjA/4VGS3b/am7TmSMV5zev2F j2bXtRoUgfI3uyHAe/1sHhgu4E2LY34o2n8TK/lD5c+e259cO2FKeIJ2PjYEFLQFwNp7 JxUKQU7QlB+ZbG1xMOMfJzGIQT2qKTbJISt2z0+lKAnLtmggojnmpnuIfIwC08VvtViE ZCCAenRUaWRaHpsv6qBWlV+7m8j2PWxa1+X/OpJUQCzNZcNLs4KCYpf202zfPxWWM1pb gx0pziEROXj9Hn/r6MqmqK7UCrLsIyuWyN+W0H4mWKZbD0IE4f3K9yGZkPsd9w0vRfnP wjrg== X-Gm-Message-State: AO0yUKVAkhmxSsqlukHyk94TcIBmYntJIcTCW+mXfErjnGhpjQ5YASxU VD580KM4gfmNHUmYG3a75Q8= X-Google-Smtp-Source: AK7set/sdOiFTHpgd/fbhMEssMMrtW2VX1HqCeNJZXIKbzhlonWR8CPVqT0Jvy8u/F1tyc65IsF9XQ== X-Received: by 2002:a05:600c:2307:b0:3ed:ed36:4150 with SMTP id 7-20020a05600c230700b003eded364150mr2510405wmo.4.1679410814916; Tue, 21 Mar 2023 08:00:14 -0700 (PDT) Received: from localhost (a109-49-33-111.cpe.netcabo.pt. [109.49.33.111]) by smtp.gmail.com with ESMTPSA id l26-20020a05600c2cda00b003dd1bd0b915sm19921345wmc.22.2023.03.21.08.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 08:00:14 -0700 (PDT) From: Rui Miguel Silva To: Alexander Stein , Laurent Pinchart , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] media: imx: imx7-media-csi: Fix mbus framefmt field init In-Reply-To: <20230321072707.678039-2-alexander.stein@ew.tq-group.com> References: <20230321072707.678039-1-alexander.stein@ew.tq-group.com> <20230321072707.678039-2-alexander.stein@ew.tq-group.com> Date: Tue, 21 Mar 2023 15:00:13 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_080019_371006_60F97D2F X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Alexander Stein writes: > 'field' is zero-initialized to V4L2_FIELD_ANY, which is an invalid value > to return to userspace. Instead fefault to non-interleaving. > > Signed-off-by: Alexander Stein Many thanks for adding this much better change log. (with the already mention fefault fix from Laurent :) ) Reviewed-by: Rui Miguel Silva Cheers, Rui > --- > drivers/media/platform/nxp/imx7-media-csi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c > index c22bf5c827e7..3e97b9f2ff69 100644 > --- a/drivers/media/platform/nxp/imx7-media-csi.c > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct imx7_csi *csi) > format.code = IMX7_CSI_DEF_MBUS_CODE; > format.width = IMX7_CSI_DEF_PIX_WIDTH; > format.height = IMX7_CSI_DEF_PIX_HEIGHT; > + format.field = V4L2_FIELD_NONE; > > imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL); > csi->vdev_compose.width = format.width; > -- > 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel