From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 419B2C74A5B for ; Fri, 17 Mar 2023 19:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6u3Qti5GOBbiFofs7unaOw19hoh5SafvMWOz0BUpsHE=; b=Kw2M6qnNFGPzC6 aIzw20tLDfCclY/YBCnWrzNy3CE+V2rUGFzdYMffl9h+xgBI/JkQELc7FohlAiQwzIS28gfl1D8eh SGz8DJT/CkmMOUCkbDxcOsIGoqjw2++kq8GgRr8+2mxbMufuqfrqxpRWiay8qkqYheDGQbFxXp1kd De2fAwrIdbary4Ty2rte0VcLC2KPc7zd54d9hWfVeA+0O0V7abw7fNZx4d4OddDhf3mBH5dJxxl3x gFw6xEkkgLZPlgkIFcEQl6792cDD2E3gdgmLk/nVjxCcHyNDNq1mmZTJRKVbP1K/hKYDZug4ue0ca X/pwjbS4WopYBRmzFysw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdFdW-003A9D-0F; Fri, 17 Mar 2023 19:21:10 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdFdU-003A3J-04 for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 19:21:09 +0000 Received: by mail-wr1-x429.google.com with SMTP id t15so5373609wrz.7 for ; Fri, 17 Mar 2023 12:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679080867; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=xDgGD9JqvaKLuvRV7fRNK6jC+CQ90lvvKb1lDMKZaYQ=; b=lIt5ROn7dM4mLQbXxtFaT+ibz7HLQMfUX6XKWqw32y8ramERbeCzsHZgBPWpmn/ION 7cjf3yP5VxIKZPmhWn3eEyXTZxTC7xfB9Ww6VKaCMy+mKUv4ERh3Ml0KpPT+y410JGCm 2zpBFyvu6oEHXGYkaykeH4jTforrMhmmnvvkkHSpcaP3urr8QcLs9OfO3GpAXQhXGrMs nKWQGZfNJPLV8/c0lEv3WA/Zat+Or5kxCxtxytBN06Ax10nIF4brlcxU5iQPdWxjbVsP 61SJTLMhH/G6F22HAp96R0ssyv2XqdqPJveRrAYNVfYyfutn3cdvU/iMMmbIwQ9K/1b1 i3jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679080867; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xDgGD9JqvaKLuvRV7fRNK6jC+CQ90lvvKb1lDMKZaYQ=; b=pP5qNLOo6B3E29a2x1IqPr30kamEMdSso1EnF05+FnbXwr70Aw3qEkHK8mSVt2HxeR npfuhVL/z+jnI8bJzw/CKMGfOwu+T7VT+GLpRmDIXyXfZBpMQuSiDEWpMGRZnU7xJZPK oc5znpSlJSahE0tpi7J5JkLGCghLF5HkLqf+pp/T6X5GPRDKav7/U0MakhLjvY926RIQ uIbsdny4u+9K/YJeXxKEExLlj5pibw621zdrAIMYsVS6K4OPfme/6h8Sc9a09unC2bTN nCiHDpT2WaO05Ej00AWmLb808UCpmRO5Yn0F7y7Ut46W99/VIGf9/V9ngy+O9rN4TjTs OBXQ== X-Gm-Message-State: AO0yUKVjrkWd2SoH1zC1WFRoPgRomwwV79/8bQSwYsAg7M5j7sIilvA+ dWvXHR+t6EKwSvJeLFVa16o= X-Google-Smtp-Source: AK7set9wl8HMItHIv7EuOF4Ugnm9G7eBifkGEcKWx1mR9Hr8rWOlN4y5AJk/0zNlMj1vAdjoy6FeNw== X-Received: by 2002:a5d:43d1:0:b0:2ca:f86a:9643 with SMTP id v17-20020a5d43d1000000b002caf86a9643mr7703391wrr.0.1679080867370; Fri, 17 Mar 2023 12:21:07 -0700 (PDT) Received: from localhost (a109-49-33-111.cpe.netcabo.pt. [109.49.33.111]) by smtp.gmail.com with ESMTPSA id h5-20020a5d4305000000b002c3f81c51b6sm2602937wrq.90.2023.03.17.12.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 12:21:06 -0700 (PDT) From: Rui Miguel Silva To: Laurent Pinchart , Alexander Stein Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] media: imx: imx7-media-csi: Fail on invalid type in VIDIOC_G_SELECTION In-Reply-To: <20230317183213.GC28322@pendragon.ideasonboard.com> References: <20230316143829.499039-1-alexander.stein@ew.tq-group.com> <20230316143829.499039-3-alexander.stein@ew.tq-group.com> <20230317183213.GC28322@pendragon.ideasonboard.com> Date: Fri, 17 Mar 2023 19:21:06 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_122108_054502_3D414245 X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Laurent Pinchart writes: > Hi Alexander, > > Thank you for the patch. > > On Thu, Mar 16, 2023 at 03:38:28PM +0100, Alexander Stein wrote: >> This device only supports video capture, so bail out if invalid >> selection type is passed. >> >> Signed-off-by: Alexander Stein > > Reviewed-by: Laurent Pinchart Reviewed-by: Rui Miguel Silva Cheers, Rui > >> --- >> drivers/media/platform/nxp/imx7-media-csi.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c >> index 3e97b9f2ff69..389d7d88b341 100644 >> --- a/drivers/media/platform/nxp/imx7-media-csi.c >> +++ b/drivers/media/platform/nxp/imx7-media-csi.c >> @@ -1214,6 +1214,9 @@ static int imx7_csi_video_g_selection(struct file *file, void *fh, >> { >> struct imx7_csi *csi = video_drvdata(file); >> >> + if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) >> + return -EINVAL; >> + >> switch (s->target) { >> case V4L2_SEL_TGT_COMPOSE: >> case V4L2_SEL_TGT_COMPOSE_DEFAULT: > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel