From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: IXP4xx: Indirect PCI MMIO compile failure
Date: Sun, 15 Nov 2009 00:37:14 +0100 [thread overview]
Message-ID: <m3fx8gwudx.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20091114231854.GB30027@n2100.arm.linux.org.uk> (Russell King's message of "Sat, 14 Nov 2009 23:18:54 +0000")
Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
>> static inline void __indirect_iounmap(void __iomem *addr)
>> {
>> - if ((__force u32)addr >= VMALLOC_START)
>> + if (!is_pci_memory(__force u32)addr)
>
> So here you're testing a virtual address against a pci address.
There is 1:1 mapping on IXP4xx with indirect PCI MMIO:
static inline void __iomem *
__ixp4xx_ioremap(unsigned long addr, size_t size, unsigned int mtype)
{
if((addr < PCIBIOS_MIN_MEM) || (addr > 0x4fffffff))
return __arm_ioremap(addr, size, mtype);
return (void __iomem *)addr;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
}
The __iomem *addr is not really a pointer, it's just a cookie which can
only be passed to the indirect routines.
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-11-14 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 20:15 IXP4xx: Indirect PCI MMIO compile failure Krzysztof Halasa
2009-11-14 21:05 ` Russell King - ARM Linux
2009-11-14 23:02 ` Krzysztof Halasa
2009-11-14 23:18 ` Russell King - ARM Linux
2009-11-14 23:37 ` Krzysztof Halasa [this message]
2009-11-15 1:14 ` Krzysztof Halasa
2009-11-15 15:53 ` Krzysztof Halasa
2009-11-15 0:21 ` IXP4xx: Indirect PCI MMIO compile failure and fix Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fx8gwudx.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox