From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?)
Date: Thu, 26 Aug 2010 18:02:46 +0200 [thread overview]
Message-ID: <m3iq2x2wgp.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20100826205344E.fujita.tomonori@lab.ntt.co.jp> (FUJITA Tomonori's message of "Thu, 26 Aug 2010 20:55:09 +0900")
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> writes:
> Lots of drivers call dma_set_coherent_mask with 64bit mask and then
> call it with 32bit mask if 64bit mask fails.
Which seems strange to me. If the driver asks for 64-bit mask and the
system can only give it 32-bits, why return an error? Every 32-bit
address is also 64-bit, with the most significant bits simply cleared.
It makes sense the other way around, if the device wants e.g. 24-bit
mask (ISA or something) but the OS doesn't have a memory pool smaller
than e.g. 4 GB then returning with error is ok.
Same with IXP4xx (and perhaps PXA) - the device wants 32 bits and it's
fine, even if the mask is set to 28 bits since the CPU can't let PCI
access more.
If the device wants to know if it should issue DACs or something like
that, sure - just check the current masks (effective).
--
Krzysztof Halasa
next prev parent reply other threads:[~2010-08-26 16:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 20:36 ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?) Krzysztof Halasa
2010-08-11 2:06 ` FUJITA Tomonori
2010-08-11 7:25 ` Russell King - ARM Linux
2010-08-13 6:23 ` FUJITA Tomonori
2010-08-13 21:54 ` Russell King - ARM Linux
2010-08-14 9:30 ` FUJITA Tomonori
2010-08-14 18:46 ` Russell King - ARM Linux
2010-08-15 5:42 ` FUJITA Tomonori
2010-08-15 8:23 ` Russell King - ARM Linux
2010-08-15 15:55 ` FUJITA Tomonori
2010-08-16 23:29 ` Krzysztof Halasa
2010-08-19 8:51 ` FUJITA Tomonori
2010-08-19 16:56 ` Krzysztof Halasa
2010-08-19 10:31 ` Benjamin Herrenschmidt
2010-08-19 14:50 ` FUJITA Tomonori
2010-08-19 16:53 ` Krzysztof Halasa
2010-08-19 17:20 ` FUJITA Tomonori
2010-08-19 21:54 ` Benjamin Herrenschmidt
2010-08-19 21:51 ` Benjamin Herrenschmidt
2010-08-26 11:55 ` FUJITA Tomonori
2010-08-26 13:54 ` FUJITA Tomonori
2010-08-26 17:57 ` Russell King - ARM Linux
2010-08-27 6:54 ` FUJITA Tomonori
2010-08-26 16:02 ` Krzysztof Halasa [this message]
2010-08-27 0:26 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iq2x2wgp.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox