[PATCH] arm: fix regression in ixp4xx clocksource

Thomas Gleixner
2011-07-04T09:21:12Z

On Thu, 2 Jun 2011, Thomas Gleixner wrote:
> > I'm really not happy about using the MMIO clocksource stuff with random
> > other read functions like this - it defeats the entire purpose of the
> > MMIO clocksource stuff. Maybe we should just undo the change for IXP4xx
> > and treat it as "special" for the time being.
> >
> > Thomas - do you have any other views?
>
> I have no objections to have special cased read functions as long as
> all the other copied code is gone. We have the same problem with the
> generic irq chip and I did not come up with a good decision function
> where to draw the line. As for everything we come up with in the
> consolidation space we need to apply common sense and keep an eye on
> the real abusers.
>
> Though in the mmio clocksource case we might ask the question whether
> read[l|w]() is really necessary in the generic implemetation or
> not. [too tired to answer that now ]

Thinking more about it we should add BE accessor functions to the mmio
clocksource as this might be useful for other architectures as well.

Thanks,

tglx