[PATCH] arm: fix regression in ixp4xx clocksource

Krzysztof Halasa
2011-07-07T06:59:59Z

Thomas Gleixner <tglx@linutronix.de> writes:

> Thinking more about it we should add BE accessor functions to the mmio
> clocksource as this might be useful for other architectures as well.

Why not simply use a value-preserving accessors like readl/writel?
Aren't they value-preserving on all ARM CPUs?

IMHO the CPU/platform code should supply certain accessors (value- and
order-preserving), and the generic code should simply use the correct
one.

Perhaps we should have (for ARM only) another set of register_readl()
etc.? (PCI and register endianness may differ, a separate set would mean
no runtime overhead in such case).
--
Krzysztof Halasa