From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D33ECE58E for ; Tue, 8 Oct 2019 08:54:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E6BF206BB for ; Tue, 8 Oct 2019 08:54:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fkrIaq+4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VXbQXbEi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E6BF206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=SjoI+SLq2uVdpm2243tOCBhW55znOjXIBHregh6JsCA=; b=fkrIaq+4GCQlhGNyjIqXF8VOyZ 1L9jQENff68OTjvCdt9yf3aIt9p7og11bOzCu13C6J/4AmYY6UG0LtG5smiw/VTAqSFVIPHHcSWd7 n7IUk8ykKRpIW/UxUXhR3tFgh8E+Ubu8iw3m1z1yfL6Qhlqq9TW3TPPRh1vEHe+1P/zpuipXmiIV5 NZmbwURZxvDLrDaxVccu5OVoQcxT1aWL8wbmm8TPn/PTN1es0taoZrNOHXQ1baalr/doa56R6ibDK k9yqVz2PVWPq2IWv+vh5gO0ojxy0ZfQr20cU+0skTxU6WMGfLFmjT9oCp+88iAffaZ0AV2L8mcMOA 2mnzd8Pw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHlGM-00034i-TT; Tue, 08 Oct 2019 08:54:34 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHlGJ-00033G-EW for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2019 08:54:32 +0000 Received: by mail-wm1-x342.google.com with SMTP id m18so2240965wmc.1 for ; Tue, 08 Oct 2019 01:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=jPjc7kEf9F+Pv9xjqePtdYZ594Xw4pebrrSpcO4H5N4=; b=VXbQXbEiRyeIqlW0AZpSfsqRElc3PukoxYh/xW9e2HGTceQ5yawq4mum9YQutGvzhI 0RLQSx6WZ33d1ebeiZyKWg2KdYU/hzjwfAl++HsNPCDFIQqrqlqOsSoazQWcJlJL01tZ 38ZpAVJ1R0scyy+S3wEqiI4JfYYMuasN8lYUUevJ4vsryturfwddfvGSXJzd07fbiyan 7tOI/H0Ghup0R9vvIp6Fg0bYBmAbF4+7ZfZ+Z+wLJBwr0dnnvfeVNXxhGu/uNm6c7ShG N01T7YXz96jpOGivMBq7UDtFKrLnuzCJc1p78wOZXdkkJnsUNR4RoJvNiZh0w37P0yiw wGcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=jPjc7kEf9F+Pv9xjqePtdYZ594Xw4pebrrSpcO4H5N4=; b=kJ20IjcFkL9guUHaS4n+6D9kGQwuPao6tgWRmVr7w3FSjnumwtPb1r+wcigLiKNEwo bN4WuLd9WVCQURU9KqNpeG2Pfgzo+yNtswLqSLo88prP9nqvbt5OafGWwcUURealCg+k KzGqPQhsNztJXNBe5BuwXRhUGcxemVfwqtjeGWSfJJvDgzNUKs4I5Y9lQSTvTo+XlniO sn0//ZEHnBKQPDRPoQXSqeaoGQU3R/HXemkt64wDIIon2jrDzPyBV0jB1LIl3gFsFxn7 nAbXRzt04jvf5R9bohsKMfy14AziRIJbCvjYHFzg4/04rw/1PfrMHddOPcagN4QLVrbI 7hZw== X-Gm-Message-State: APjAAAWp3fEFahnmkbKv9aCy6kg4JVXltMAo5a19Q6A2kv6vTySuL4IM Jjr+kFiOiL7+U+BsJftC1LQ= X-Google-Smtp-Source: APXvYqy/HvGfAU/ArSF6LuxodfAOeqkQ5yg5iRJ5pMsJAj0kWWuPbGswQqfOhH3/3PSGAbUKm97rGA== X-Received: by 2002:a05:600c:305:: with SMTP id q5mr2772331wmd.67.1570524869566; Tue, 08 Oct 2019 01:54:29 -0700 (PDT) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id g185sm1948555wme.10.2019.10.08.01.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 01:54:28 -0700 (PDT) References: <1570515459-25609-1-git-send-email-hariprasad.kelam@gmail.com> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Hariprasad Kelam , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: imx: make use devm_platform_ioremap_resource In-reply-to: <1570515459-25609-1-git-send-email-hariprasad.kelam@gmail.com> Date: Tue, 08 Oct 2019 09:54:26 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_015431_515030_475C4358 X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hariprasad, Thanks for the patch On Tue 08 Oct 2019 at 07:17, nobody wrote: > From: Hariprasad Kelam > Something went wrong formating the patch email, no To: nor From: > > fix below issue reported by coccicheck > drivers/staging//media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use > devm_platform_ioremap_resource for state -> regs > Sorry, but someone else, Jeeeun, already sent a patch for this [0]. Thanks anyway. --- Cheers, Rui [0]: https://lore.kernel.org/linux-media/m3wodvgec4.fsf@gmail.com/ > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354..bf21db3 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -947,7 +947,6 @@ static void mipi_csis_debugfs_exit(struct csi_state *state) > static int mipi_csis_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct resource *mem_res; > struct csi_state *state; > int ret; > > @@ -969,8 +968,7 @@ static int mipi_csis_probe(struct platform_device *pdev) > mipi_csis_phy_init(state); > mipi_csis_phy_reset(state); > > - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - state->regs = devm_ioremap_resource(dev, mem_res); > + state->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(state->regs)) > return PTR_ERR(state->regs); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel