From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AA3FC83F17 for ; Thu, 31 Aug 2023 09:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6b+tTIazWunFxvegoSC9GqOyJd5IbcrmcvCLQqhsTsY=; b=rUotjZvjvcDzsb 50qrSmzpbV/Ha/Zyyo+gg5mCp31iafjDe5X1DXdt3v/xUHIn6021z8MUVLXFWnJS3hjwQwzxoIorj WhVAYO2yprgibBrIYvg6mHt6ZqgQMvo48lnDfTuBkZDA7kPgLktTerVlYwzW9dQGxKoNLrsEdumkO PKQF85zc8gF4S98MUP4c6OQTCQXZj2SXMUm944kUxbPNvxLZoaMTuxwlvwQuVbu27JY3yK9U71fbc TiQI9QcJ0CpwEC6nfPNFckYkjyT/ZF1jzp/lqfWlMmp5c0Zp7w/8+a6O/HvWbMRZ1zMPY2kQLE07j CnT9Ak4Y4In6/X2n19XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbdnP-00Ew8o-1n; Thu, 31 Aug 2023 09:16:59 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbdnN-00Ew8O-0f for linux-arm-kernel@lists.infradead.org; Thu, 31 Aug 2023 09:16:58 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-401da71b85eso5327845e9.1 for ; Thu, 31 Aug 2023 02:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693473413; x=1694078213; darn=lists.infradead.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=0dnYJvLMIpANPASquNaD9gnfxzlO89jbOPtXwZ31rbY=; b=gXNE9jXEEXxhL1w0AgRzIhVwSA4jyaKoqPgIdNVwsKT82K9Y8vhE0WZ/X9NAmiDLFL aNV7GEuYXoFnAOX3VKXDGkHvpDyeIYhIOcj3KSzz5MzB7j+Kti4UdPvTc8+J/yE8v24g c5LkExIiE06yscdnlidmRUAYK93Am9rWUfd6e/6XQ4MxZLHBT17ob0W+6OuoMN5z5acZ aLdT6+eONLj95jrhR9aSCJH61Ratm531kZSzp2qDZM5teiwV/MeMmZ3CQroV2rQT4wGp Nd51D0TPHUESh7EGtEdt0iB4/Q98iSd+D1W7KE9bfvYcEULl4P6NOPdKDuQarglppS9A WBxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693473413; x=1694078213; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0dnYJvLMIpANPASquNaD9gnfxzlO89jbOPtXwZ31rbY=; b=jeIIXzeUARYkBS4RR9uXBaM+UE4psqOeY5xebVz9zchwvtren30wP6VrmDIu/rWJsC qy0ElU7PzZ/9Sp8T3nCG3uhOaaXCsojp1WE4JnNSEB6BBGee06Kudc6G+eAwp6DJNBEr nb+Epz23053nfQ6FvR3qqv2AV66D+x0jIqnpCbx2SvbS99X0f6FRNB+kj/fj7P1ZfGZZ XSkQKYzLQ1YkvlTMKOGjUmGiwb8TVFLdZNV57mfDh1//iRf/J4z6zsaxwDKOKXviTlGm oO4LQMuR4MAglX+wx1cNrGt9GBIko4jBgJAW7zNLkXcyCRuMh1lgSAF5diRKP4OlYxWc b54Q== X-Gm-Message-State: AOJu0YwW0ztpf0fFf63WLPQtjgaEONoQTnanfEL5+QjPYfIIiKHVDvAU bhzrgRPybJCpYIhynR897ko= X-Google-Smtp-Source: AGHT+IEEC/IOcwAaa1oeciqMKRGj3e18yNmGwPrz8uNum8h2wf2Xg6roNPMd7mlQPgS5E8Sgdk5faw== X-Received: by 2002:a05:6000:110a:b0:31a:e87e:103 with SMTP id z10-20020a056000110a00b0031ae87e0103mr3103180wrw.48.1693473412883; Thu, 31 Aug 2023 02:16:52 -0700 (PDT) Received: from localhost (a109-49-32-45.cpe.netcabo.pt. [109.49.32.45]) by smtp.gmail.com with ESMTPSA id b2-20020a5d45c2000000b003195504c754sm1528513wrs.31.2023.08.31.02.16.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 02:16:52 -0700 (PDT) From: Rui Miguel Silva To: Christophe JAILLET , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sakari Ailus Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] media: imx-mipi-csis: Remove an incorrect fwnode_handle_put() call In-Reply-To: References: Date: Thu, 31 Aug 2023 10:16:51 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230831_021657_261458_52D8043C X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christophe, Many thanks for the fix. Christophe JAILLET writes: > The commit in Fixes has removed an fwnode_graph_get_endpoint_by_id() call > in mipi_csis_subdev_init(). > So the reference that was taken should not be released anymore in the > error handling path of the probe and in the remove function. > > Remove the now incorrect fwnode_handle_put() calls. > > Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") > Signed-off-by: Christophe JAILLET LGTM. Reviewed-by: Rui Miguel Silva Cheers, Rui > --- > drivers/media/platform/nxp/imx-mipi-csis.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c > index 16f19a640130..5f93712bf485 100644 > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > @@ -1490,7 +1490,6 @@ static int mipi_csis_probe(struct platform_device *pdev) > v4l2_async_unregister_subdev(&csis->sd); > err_disable_clock: > mipi_csis_clk_disable(csis); > - fwnode_handle_put(csis->sd.fwnode); > > return ret; > } > @@ -1510,7 +1509,6 @@ static void mipi_csis_remove(struct platform_device *pdev) > mipi_csis_clk_disable(csis); > v4l2_subdev_cleanup(&csis->sd); > media_entity_cleanup(&csis->sd.entity); > - fwnode_handle_put(csis->sd.fwnode); > pm_runtime_set_suspended(&pdev->dev); > } > > -- > 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel