From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E744C6FD1D for ; Fri, 17 Mar 2023 17:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=49fgFyZ1m0Dct8dgpZRzKf2Xz103tZeI9APAHyDpDgQ=; b=KvatG7qdlg6n8q IGr/Vy2Ce6qbfik4BcR1ozcZZvVQac0bwTG8rqeyqa6VF/fCykdkvWL4Fbz7v1vjUFsReD5t0yPlI unmEPAV2fZQVwi3ymPpITulaIoFRM5AVPfoDm0YAvj4OSTxcb+JE1KX9IV/dIxzoYLp2ym2EL1gpg A0cuY1k8wmAVzhJEq2zx2jjGu9wYTllCIeaSbYxjxAC208pbqVg2v5hBKE6yoGNMmo1Dsf6/u0Cgy XnS35zeyTuxXURVn6CzaVMinxSOIpk7Z4eTvsK0hILps2d1jfXiNhBKFz+plonv3rPgJ7VNAve2v3 DLw91v+OdAH2+gQv5IAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdDns-002sRg-0x; Fri, 17 Mar 2023 17:23:44 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdDnp-002sNS-21 for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 17:23:42 +0000 Received: by mail-wr1-x436.google.com with SMTP id r29so5095727wra.13 for ; Fri, 17 Mar 2023 10:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679073811; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=cD4duTKtxPjB04x09d+p9kcjB4mylat5Nf6rGmQI1U0=; b=WRlD8gXGdGyMhrAT0Y6VG4bSklmwgvYAyP+TlixxX2aUoQsv3u3SmP6bi96fFoWezO YKcSvofKxEj6sVIK9Zw0PrPUpD5BjwVU47e+cdXbuKn17Ksrj6NSgvDLc8Ehxf1ka0qo MEC48d3h6VknqE+ZRO12jgYoXl/IDEpblPoBqXGZln0t/Kj/G9C9wngCvbTvdDqPK0Pf 3wtTVWsSrzvzHUE9K1g3D7Ii5gHUVm4fAEvm3JHyXuurCK2+XX3Sqz5aE5thR21vc8sc h9AgyM03vZZfpTq/NYFmLdWprL3j6pXIo5pnUgPZLAja4TGwnU/DUlb67IfRwRZ7Dgpq DCew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679073811; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cD4duTKtxPjB04x09d+p9kcjB4mylat5Nf6rGmQI1U0=; b=IUC0meNRvEKIZsZlXyl1kcBpcoaCf9v5cQVAF/j3aoO3HXt1pNM947h9SUWG2L5qJq U6PXzFcoDBz8Xr95Iu2BviZMlOqeerwE6Ig6L30kNS74+tt4JDVtw1sxt3okJoVHxh2f r9g9gBOU6lzUc/jX97kWbmrPBUGTeD88dmWfDzhg6vSqCM9weOxYOZKFCDSt+j27Hywm kDGdnxSsfIFARUCnqEaXzU1tWOJZle6pTfz0ccEPSzdPCBMR4i52fDxev1Lb57qNVY6r YbXdJUcZ9ACV4dSX7iaJZkpWvBX4EwawvzGqHiZTpmGOvuGMVAnbdFmepT41gHoPYz50 8prQ== X-Gm-Message-State: AO0yUKWN/U/fhVhzAoCy03aw55oruhfgK27zlAyd1SE8e/RRXhtT1Exw LLo1ydH3vjqL2hzSw/2/RxA= X-Google-Smtp-Source: AK7set+khR7sfHbrOB23qGhEm1L0AJjHdpqzNDSucKBpt+gO9poP++QCURdmSqc4ddOWKeh9uyUynw== X-Received: by 2002:adf:db46:0:b0:2ce:aad8:9bee with SMTP id f6-20020adfdb46000000b002ceaad89beemr6639020wrj.46.1679073811449; Fri, 17 Mar 2023 10:23:31 -0700 (PDT) Received: from localhost (a109-49-33-111.cpe.netcabo.pt. [109.49.33.111]) by smtp.gmail.com with ESMTPSA id h6-20020adffa86000000b002c573cff730sm2422376wrr.68.2023.03.17.10.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 10:23:30 -0700 (PDT) From: Rui Miguel Silva To: Alexander Stein , Laurent Pinchart , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Alexander Stein , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] media: imx: imx7-media-csi: Fail for non video-capture formats In-Reply-To: <20230316143829.499039-4-alexander.stein@ew.tq-group.com> References: <20230316143829.499039-1-alexander.stein@ew.tq-group.com> <20230316143829.499039-4-alexander.stein@ew.tq-group.com> Date: Fri, 17 Mar 2023 17:23:29 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_102341_662903_2DB1CA0A X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, thanks for the patch. Alexander Stein writes: > This driver only support V4L2_BUF_TYPE_VIDEO_CAPTURE, so fail for other > passed types. > > Signed-off-by: Alexander Stein > --- > drivers/media/platform/nxp/imx7-media-csi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c > index 389d7d88b341..e470b0505d3b 100644 > --- a/drivers/media/platform/nxp/imx7-media-csi.c > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > @@ -1186,6 +1186,11 @@ __imx7_csi_video_try_fmt(struct v4l2_pix_format *pixfmt, > static int imx7_csi_video_try_fmt_vid_cap(struct file *file, void *fh, > struct v4l2_format *f) > { > + struct imx7_csi *csi = video_drvdata(file); Maybe copy/paste problem csi is never used. > + > + if (f->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > + return -EINVAL; Is this function ever called if f->type is not TYPE_VIDEO_CAPTURE? > + > __imx7_csi_video_try_fmt(&f->fmt.pix, NULL); > return 0; > } > @@ -1196,6 +1201,9 @@ static int imx7_csi_video_s_fmt_vid_cap(struct file *file, void *fh, > struct imx7_csi *csi = video_drvdata(file); > const struct imx7_csi_pixfmt *cc; > > + if (f->type != V4L2_BUF_TYPE_VIDEO_CAPTURE) > + return -EINVAL; Ditto? Cheers, Rui > + > if (vb2_is_busy(&csi->q)) { > dev_err(csi->dev, "%s queue busy\n", __func__); > return -EBUSY; > -- > 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel