From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A82C06510 for ; Mon, 1 Jul 2019 09:44:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18EFC20B7C for ; Mon, 1 Jul 2019 09:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cj7hSGju"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FqCGWxP0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18EFC20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UrgI46ZJEKMeko7+Z9DnJEvhzW3rXqS6impzJvFGm5E=; b=Cj7hSGjujx3+RkSCWExWyFS0Vx N0xVlClZYi8Dl5Emg+pjtEMWCJDdTlwbW0ru6SnaoSAe23QaJzWFgGuAXs4Otc9xNiSJ2cqlViu+7 B12CxM0SvUtBa3IZdiZSvxzm3n36Xqo5X9yq2vc+lR3CBzdyw1emEMbw9W2UTz4hsyIUlRWQ4DviY 8Ook6KLCB6EEFD3Krg8kow8imw1HZIzHU1ZpoP3ugZRIyTz5uinC+8v3mstlU4pplpBlrTlXbSiiH kvjqocuFJR+K5smsY9tHMrsMfeZhhyiWOyTbZLivwF6OHDqVYRH+ED3PMItEyMuCsaXrBxwpGI6cj ENiWjwEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhsr9-0002Lr-6K; Mon, 01 Jul 2019 09:44:15 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hhsr6-0002LX-8d for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2019 09:44:14 +0000 Received: by mail-wm1-x344.google.com with SMTP id f17so15126954wme.2 for ; Mon, 01 Jul 2019 02:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Wpl34t7pEEK79q3TGA4TYVX4j5sGst2FWPYV+cG9ZgQ=; b=FqCGWxP07Zk0mb9fi11yD9qbrg46ZxDMf6TAAhLTryUorNkAmjegD69qSKZQzKeIAn 0s89ug6dEwg8L0+BEBBSAbCf3g7qTgsCUBh9aAp/nvNjGM8ZrPGOJ280HS1mn3PPt6Z7 FkiCK9ryGXe48hSKSavf2BCdkAKZu00flMMqEcqN/jFRxbVO3clzXy/B8lAGQZUlUVDO n1l1VBVNK+FV3ZQJub7OuYXT9EBfLgwg2wubv9lMt4KR4F4cylnh2M6SjInEyoyQCXKW kc8jNbl3hlbq5zuOc2yJ9EOknAXMTPdnQNsJSJxTTDIFVtpvdh3rG4ZzuKYfGwhpSLPD afbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Wpl34t7pEEK79q3TGA4TYVX4j5sGst2FWPYV+cG9ZgQ=; b=EPZwduQdJrGoAC91ea6mBxTXfq3e4fLso/qAh8Aoyt42bbl6zVhbl8YmHsoLLBI2Cu gn1Bnny4IdqLaqa6tvRlC3O9ERBB3SaumpTXILQJg32tk75P1GLBaV8WiSeRdqSiz9Tv t6IvohpTFVbExjjANYLP7oLFViW3xbZO3HfMHy5+whzHjEPA3HXz5/1hTss+P6Qs1YsV YZhn1cp9P0EXkzxLq/h/MyI4x6IWG/3AfrAursUXYDsrjtnUc5H62TWuxKv62gkWwkqC z31vHNHiXVPh7ol+dMYsll/gfRRKJPlAlxgiQIsVx6HU82QtTJvzE4zzkaeLhVtRvw92 3Luw== X-Gm-Message-State: APjAAAULV55oliflZMs8Z06bwkvbLZGKbqIleGSOZEV5dNsu23V2jyqD EAcI9hZTLxWNk/senZA4Yw0= X-Google-Smtp-Source: APXvYqwE+Q7AnLDk4oMLFL/k5V2IsWF4NCm7kbDDvvTbUOZGjDlQHcN8+h+kh/QLkteSGPRbtaW/5w== X-Received: by 2002:a1c:9d86:: with SMTP id g128mr17778545wme.51.1561974250603; Mon, 01 Jul 2019 02:44:10 -0700 (PDT) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id f21sm9951878wmb.2.2019.07.01.02.44.08 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 02:44:09 -0700 (PDT) References: <20190630034905.7124-1-chinmaya.mahesh@disroot.org> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Chinmaya Krishnan Mahesh Subject: Re: [PATCH] media: imx7-media-csi: Remove unneeded break after return In-reply-to: <20190630034905.7124-1-chinmaya.mahesh@disroot.org> Date: Mon, 01 Jul 2019 10:44:07 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190701_024412_302828_83188EB9 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Fabio Estevam , Pengutronix Kernel Team , Greg Kroah-Hartman , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Philipp Zabel , Steve Longerbeam , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chinmaya, Thanks for your patch. On Sun 30 Jun 2019 at 04:49, Chinmaya Krishnan Mahesh wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: break is not useful after a goto or return but this is already fixed in the media subsystem tree, by a patch from Fabio: 964fcacddf media: imx7-media-csi: Remove unneeded break It is better to use that tree as reference for media fixes, sometimes some are already fixed there. Nevertheless many thanks for the patch. --- Cheers, Rui > > Signed-off-by: Chinmaya Krishnan Mahesh > --- > drivers/staging/media/imx/imx7-media-csi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c > index a708a0340eb1..c15acca1dc0d 100644 > --- a/drivers/staging/media/imx/imx7-media-csi.c > +++ b/drivers/staging/media/imx/imx7-media-csi.c > @@ -1021,7 +1021,6 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi, > break; > default: > return -EINVAL; > - break; > } > return 0; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel