From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: IXP4xx: Indirect PCI MMIO compile failure
Date: Sat, 14 Nov 2009 21:15:54 +0100 [thread overview]
Message-ID: <m3pr7kyi9x.fsf@intrepid.localdomain> (raw)
Hi,
Guess nobody uses indirect PCI MMIO on IXP4xx - since 2.6.29:
arch/arm/mach-ixp4xx/include/mach/io.h:70: error: 'VMALLOC_START' undeclared
(and so on)
That's a part of commit 4b78a9ffabbb03af4032ff704689912298e19070, dated
2008-11-29. Perhaps we should get rid of this hack (indirect MMIO) if
nobody uses it? 64 MB of MMIO PCI space should be more than enough for
everyone :-)
Since VMALLOC_START wants high_memory, I guess the correct patch is
(attached) and that's what I'm going to use if nobody comes with a
better idea.
--- a/arch/arm/mach-ixp4xx/include/mach/io.h
+++ b/arch/arm/mach-ixp4xx/include/mach/io.h
@@ -14,7 +14,7 @@
#define __ASM_ARM_ARCH_IO_H
#include <linux/bitops.h>
-
+#include <linux/mm.h>
#include <mach/hardware.h>
#define IO_SPACE_LIMIT 0x0000ffff
--
Krzysztof Halasa
next reply other threads:[~2009-11-14 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 20:15 Krzysztof Halasa [this message]
2009-11-14 21:05 ` IXP4xx: Indirect PCI MMIO compile failure Russell King - ARM Linux
2009-11-14 23:02 ` Krzysztof Halasa
2009-11-14 23:18 ` Russell King - ARM Linux
2009-11-14 23:37 ` Krzysztof Halasa
2009-11-15 1:14 ` Krzysztof Halasa
2009-11-15 15:53 ` Krzysztof Halasa
2009-11-15 0:21 ` IXP4xx: Indirect PCI MMIO compile failure and fix Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pr7kyi9x.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).