From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28991C74A5B for ; Fri, 17 Mar 2023 17:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FFJQg59Ix7KOdtTu8P7ksVTXhgnwDwuCRfTGJlE4ij0=; b=LlfMhgxU9/1Fy3 mtO2nIl1qps/JteZKQjrmvD9ghv2n/ReekjCHDvFblqZOXp4y7uiEXW8Hq7hhWfbtBHCij30myh/c WmX9ACwK7IkIjUaUSJf7eaxoubcIl0nVKMuhT4YRz2wMLQqG31UISVWZQxwfc3RlFp/EMpeMgJWvS Zt0tIl0fRbo1nNUsxEkK49xm3J2kz2H8kZT1hM2R0+HBi9pwE4UbS9+WgScpI48eyfkEaaevQy1fx NvV8kXvB44CeG9p/tZGRaui5eW9zkCnXMQit65ErExDIOP/G4Op0eyEKYfjMz7OZ/iL8aUMxPiZuN Aa9TFoC0/UWZV/CvvMIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdDlG-002rrg-2F; Fri, 17 Mar 2023 17:21:02 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdDlE-002rpj-0p for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 17:21:01 +0000 Received: by mail-wm1-x331.google.com with SMTP id m35so3811557wms.4 for ; Fri, 17 Mar 2023 10:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679073657; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=qBXUX1ewVGliH2qbyG+NOLH5sHkCboCsAmAn6tWfaSI=; b=C39B7bz4syjKd+MEqnCiL0qwT4ZPMK++5XDkmdcsR1jYZP4nRQcjqZAuz2EtZsgfN0 q7ljEx9u/j7pQdRS9lRyEZ/1bVVpHHCf7LqKylNuv60eYl+3eiaf8Fa4AF6zMD5n/UEf 6cvGP+241StV3SsjFj71ueJPTcOV3XanC591KtDANg9HeT/tN7nTGlbeZlD3CoN9RVMY JUNoGY8smUBK+1Cl4Dql6skMPAJgZ2NKlJVOuFenWCLvZu2jB2xbDsBQyjFhuGK5CSyH jNy/iChFaX6cXw+LvGWL953npxX5TpOm+H3tzBjWhDLFAWVArUocsLK6plMlW3bb4gjM y1vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679073657; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qBXUX1ewVGliH2qbyG+NOLH5sHkCboCsAmAn6tWfaSI=; b=Eqm4FEp3a/WyeqV/GPTJrm/pBW5PolarivhvPgJMug+s0OBRht0IcVkhPub6+MxqDN PrgSIwzzFZtMjKOjfPj5i3oIWwyRTg0Jnp+nrfUMCWw0BI+/b2nW25ezhwujsXGaIA3M qf7297EKeEU6sG0jRVWp8J3w/dZpCUTdk6kyMl2YooSrkMO0uRg33s1+qTH2oJkQW+Wa OLt8BMErZ5tlMZmZEaPaiwvmV+1ag4PIWWUZBZnnYrBQktSu9v6qKCCUADHJJ8BNVWfN 0f9XcLIALQNWlRy5YaKkbiUlWHJORuGsqHVbxYAFKMxcCpwV1EWlYuiDitY+W2k7hlKB Z1RA== X-Gm-Message-State: AO0yUKUj3Rx8so0AAqYAjxGtH3zfOIiqXI4u5gv8eZ04LmTPwVqd3QPR xmMIFLffOdlyQzhIo0d2LKU= X-Google-Smtp-Source: AK7set93quNvl9XqYzMK7ssB9IZvr4tBa5yjli80z3VRJhiTMbh7gNLAYvP959gf89qaX9R7zksHHg== X-Received: by 2002:a05:600c:4ecf:b0:3ea:e4bb:340c with SMTP id g15-20020a05600c4ecf00b003eae4bb340cmr25799917wmq.18.1679073657413; Fri, 17 Mar 2023 10:20:57 -0700 (PDT) Received: from localhost (a109-49-33-111.cpe.netcabo.pt. [109.49.33.111]) by smtp.gmail.com with ESMTPSA id bd20-20020a05600c1f1400b003e21dcccf9fsm8402684wmb.16.2023.03.17.10.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 10:20:56 -0700 (PDT) From: Rui Miguel Silva To: Alexander Stein , Laurent Pinchart , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Alexander Stein , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] media: imx: imx7-media-csi: Fix mbus framefmt field init In-Reply-To: <20230316143829.499039-2-alexander.stein@ew.tq-group.com> References: <20230316143829.499039-1-alexander.stein@ew.tq-group.com> <20230316143829.499039-2-alexander.stein@ew.tq-group.com> Date: Fri, 17 Mar 2023 17:20:55 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_102100_290771_30186152 X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thanks for the patch. Alexander Stein writes: > Default to non-interleaving. Why? > > Fixes: bc0d3df31ffe ("media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format()") It was never init to FIELD_NONE even before this patch, do you think it is really a fix? Cheers, Rui > Signed-off-by: Alexander Stein > --- > drivers/media/platform/nxp/imx7-media-csi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c > index c22bf5c827e7..3e97b9f2ff69 100644 > --- a/drivers/media/platform/nxp/imx7-media-csi.c > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > @@ -1610,6 +1610,7 @@ static int imx7_csi_video_init_format(struct imx7_csi *csi) > format.code = IMX7_CSI_DEF_MBUS_CODE; > format.width = IMX7_CSI_DEF_PIX_WIDTH; > format.height = IMX7_CSI_DEF_PIX_HEIGHT; > + format.field = V4L2_FIELD_NONE; > > imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL); > csi->vdev_compose.width = format.width; > -- > 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel