From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9104AC10F14 for ; Tue, 15 Oct 2019 08:42:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 600C12064B for ; Tue, 15 Oct 2019 08:42:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OJGp49K3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HPC6BuNV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 600C12064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2IjbI1xtT/LDTiQ9LDOj3/mFqVcmwY21phupY6DUcao=; b=OJGp49K34YQI0NDcnXXEivkb7a JoAEIne29riJlRjwYXbf87WZMV/Ovuf5PJihR54rBO3bTGX6OjeUY+0Esb5nrXdZF5JmdO6OokaBO gOK+8TbcVWT6FLTkKSLoQ6OOzmX2jq4AShjSc0SPBqPV2UTxQOrtJJOZ41qNrj3TBrWzSWb2sMXCj J9vQaHXQfJtijzfyzq/HmEdB5Bp31r2D+Azvmx01uTzaq/nvOnj0v7zBe6sz1BVUBHh6BoLaND/8E Q7hGubVS9InQ+vnyik0Jcd1CRylksXnc2rbYGi5DNCxIVQr98Ca0ztQ1TwkD/I/SzA6Fvg039cC+Z LEtfV/cQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKIPS-0001Ul-6E; Tue, 15 Oct 2019 08:42:26 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKIPN-0001OY-Al for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 08:42:22 +0000 Received: by mail-wr1-x444.google.com with SMTP id n14so22706620wrw.9 for ; Tue, 15 Oct 2019 01:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Alk2iYvP1zhS1Vsxyz1ENDltR7DNnK/DdAFNKV0PUVw=; b=HPC6BuNV8j9u4GZjxKCxoY5RREbeSrCviqnJSe7bX9+Mz4/Ou/Y9YJfCz9D6x5YDJN FPfze7R3WjjunFuZ7BTxjlj9zeZRJzIv5QwElj6bGpHm80r1uAkybYsje5HSVM+2NFwg okWGBK3N+IHtYpPvyQqh8PWgleHiWLfaTVIU08wX80EZFskkvb87rkGeRvnDWfk89KCu IgJWRobMxvlThOjJFQ8cTYimw/cyOOpegxEHHwfkSkuivf2kzEL9dFf5lp0/093hBmrI I+I7fkoLrJo0gxg6wqlRIw4tvg+AF768tPLChUkL43L+S3EzP1I5VV2vB2RtSVkqAj5v MBHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Alk2iYvP1zhS1Vsxyz1ENDltR7DNnK/DdAFNKV0PUVw=; b=f228oPkCprmJWXf+QsX4WW/A024eWz7ZxC7727RGCWkRK4ZP8Cd/4y/7340N4U7H4H EYOV6m8OW2gqdoFT7qtXTu4lkAEGVkc/M2BAHrbryukYprEA5tTlhjVOrmJu9JPkP04d +vbZJLJV2zYgpIPkPdHpYr0EP9EbT5B7OT0O+WPP1QOOIISHl9xgFnEyXhkV/4LQJTyV 3xO/hyAyRSY3XwLEiAJ4DCpog7lRIM+j87udNvMm14mJFANjkRMy1SDLSealEI4dXNZL tbx+Qjwd3VrIoGhnFm51IYmeJITYyu3m1hiEJZkiV4xSJhbOvOfCFUEV+YXl5RRoiSIw eouQ== X-Gm-Message-State: APjAAAWFc1312oDxMRsky9GrTde8SvEVp3B18TsLVf5tZ+kyO0q0trGd HPvEzF/RDeowH//DFJlxh+w= X-Google-Smtp-Source: APXvYqx2bycIPnDtHKFh/xJsJXsS+Tg6XyXhmAOeu2Ar9KLDQ3WxO6d6EJTK67tMcZ2zx3XYKeedhw== X-Received: by 2002:adf:e40c:: with SMTP id g12mr30931259wrm.216.1571128939235; Tue, 15 Oct 2019 01:42:19 -0700 (PDT) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id u10sm19454220wmm.0.2019.10.15.01.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 01:42:17 -0700 (PDT) References: <20191014020847.9203-1-hslester96@gmail.com> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Rui Miguel Silva To: Chuhong Yuan Subject: Re: [PATCH] media: imx7-mipi-csis: Add a check for devm_regulator_get In-reply-to: <20191014020847.9203-1-hslester96@gmail.com> Date: Tue, 15 Oct 2019 09:42:16 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_014221_374449_8B139744 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Fabio Estevam , Pengutronix Kernel Team , Greg Kroah-Hartman , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Philipp Zabel , Steve Longerbeam , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chuhong, Thanks for the patch. On Mon 14 Oct 2019 at 03:08, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regulator_get to avoid potential risk. > > Signed-off-by: Chuhong Yuan > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354e618c..9a07b54c4ab1 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -350,6 +350,8 @@ static void mipi_csis_sw_reset(struct csi_state *state) > static int mipi_csis_phy_init(struct csi_state *state) > { > state->mipi_phy_regulator = devm_regulator_get(state->dev, "phy"); > + if (IS_ERR(state->mipi_phy_regulator)) > + return PTR_ERR(state->mipi_phy_regulator); This regulator is marked as mandatory in the device tree entry, however it looks good to me to have this check, even because it can return -EPROBE_DEFER and we need to retry. But for that we may need to extend this patch to make the caller of this (mipi_csis_probe), to also really care about the returned code. Cheers, Rui > > return regulator_set_voltage(state->mipi_phy_regulator, 1000000, > 1000000); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel