From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: IXP4xx fixes
Date: Sun, 23 Mar 2014 00:44:09 +0100 [thread overview]
Message-ID: <m3siq9iyt2.fsf@intrepid.localdomain> (raw)
Hello,
I'm attaching 3 IXP4xx fixes:
1. Fix Goramo Multilink GPIO conversion (regression in v3.13)
This platform is not included by default and it seems it escaped
testing when the GPIO was converted.
I've noticed a patch fixing the same problem from Arnd Bergmann,
however the other IXP4xx platforms now use the GPIO API and
I think this single platform shouldn't be an exception.
2. Fix DMA masks (regression in v3.7)
This patch makes IXP4xx conform to the DMA API. Newly created devices
will have 32-bit DMA and coherent DMA masks (effectively 28-bit for
PCI devices). dma_set_coherent_mask() will now really set the mask,
not only test for its validity as it used to.
A subsequent cosmetic patch for specific devices (e.g. built-in
Ethernet and sync serial) setting DMA and coherent DMA masks may be
needed, however it won't have any effect on the regression. Simply
speaking, it's the core IXP4xx code that is broken (since the
beginning I think), and it's where the fix must go.
3. Fix DMA-bounce code to allow sync from_device and to_device with
bidirectional mappings.
This is an issue on (probably) E100 Ethernet only. A known problem
but few people ever cared. Fixed on X86 long ago.
BTW this passes cleanly through DMA API debug. And it obviously
works correctly.
This stuff is tested on Goramo Multilink and on Gateworks Cambria with
both on-chip and PCI DMA-able devices.
--
Krzysztof Halasa
next reply other threads:[~2014-03-22 23:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 23:44 Krzysztof Halasa [this message]
2014-03-23 0:34 ` [PATCH 1/3] IXP4xx: Fix Goramo Multilink GPIO conversion Krzysztof Halasa
2014-03-24 15:27 ` Linus Walleij
2014-03-24 20:36 ` Krzysztof Halasa
2014-03-26 22:06 ` Arnd Bergmann
2014-03-23 0:36 ` [PATCH 2/3] IXP4xx: Fix DMA masks Krzysztof Halasa
2014-03-24 13:50 ` Simon Kågström
2014-03-24 20:30 ` Krzysztof Halasa
2014-03-26 22:08 ` Arnd Bergmann
2014-03-23 0:38 ` [PATCH 3/3] ARM: Fix DMA-bounce code to allow sync from_device and to_device with bidirectional mappings Krzysztof Halasa
2014-03-24 13:51 ` Simon Kågström
2014-03-26 22:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3siq9iyt2.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox