From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 034C4C10F05 for ; Wed, 20 Mar 2019 14:40:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C713221873 for ; Wed, 20 Mar 2019 14:40:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nmIYGci6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vzd125ZF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C713221873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZrF1UnTrr2ho7Fx8w0ZpIaq7+FegBUg/Lyk9fogpXtI=; b=nmIYGci6U/VSyOUVuQlEMwZ8k dXiAiAS39poA2tCYGkxjDmdUpd6O+WpfUkwKdKp4Imgb7p7TzuMdOX5odFAsRPeFeeypspwHBvyHz Y81+AIYj8/e2TNH0fJFXUTevzmbcJNUNeZB8r029zX5hcI6YaE5N4RbY42xTZJuaSVovppi6nzwG8 w/rnQX1x//anPQnQXR0ipAkgDcnTz9UlXyBu/EL8ea2FADBDiUSLqIM9ymswN19WWSE45lJrgb5Tx Lv9eaxt1XKgy9ZOHcXgFx66BKIZ8nlPhJIi1R1Z76sxQdi1Fo+SPc713GAssmClL8XPmYitlYXZ2A Ob5LdkbxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6cOM-0003gq-Cm; Wed, 20 Mar 2019 14:40:30 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6cOK-0003gW-69 for linux-arm-kernel@lists.infradead.org; Wed, 20 Mar 2019 14:40:28 +0000 Received: by mail-wm1-x343.google.com with SMTP id a188so20348571wmf.3 for ; Wed, 20 Mar 2019 07:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=63lUCKzou0hKfO0w+V6Cio4BeboSTxW84Eh4nTzwxsM=; b=Vzd125ZFTuWtYphi13aF3UM8xmSExJHfC09VqlBSXM8QEGQGkjj8a/G4u0xUVWxq50 KGActoHGWYrUoQpD/4Y6TbIDbZTD/OSlbXa4cifeXn070lCv6Y6avSJeYpuc3yYEkTOH OIyr45wPD/TkW5CTa/cIjmnT2+t7vuupwABMfV1LVN3j9Dfk3CWuHcPaIRh/OaNulhe6 1jy6LcJ1R953IFmkyYWSdlsSK3a6TlSfh/v3mFWcnDdRk/wsna1BGs91I7SaZspRHIk1 u/ByT3PZteHrWOeJ6/s8IDC725sao0KCFqbYqZWb90RaIgz+CZ6hOAJAPbG0RSKjDjGU pGUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=63lUCKzou0hKfO0w+V6Cio4BeboSTxW84Eh4nTzwxsM=; b=iK4YJExRPRnPhDOUO9cCs01aiG1/737m96muWf7EJ2b1bR+UTW3XMqtv3XTzwDde// fYGFR5Cn7e7TbCSPGGsnhIxXr4Rv8Mo9sWLjzNVn0G2RIZC3PyMAwvkYWhemuvHTTScf I20gfdEKW12VaxJcvn86BnDimeD9PW237wzhcOqIN68tOirhe/NFT9n0XbvfsVtcGrCf f22sSG/N1SLrkjxTEBXstRlrQc5IPXZfjLhWuWdpRqyCm46ewDItg8k3l1h5Tp9dDTXi dF+sm8QIdgO5NEOzYhz4tYQMix/7u0sGT8/t4a/dbJftXOBtEWfgZrL7qTOJkmREIZAp vqTA== X-Gm-Message-State: APjAAAXyHjliWPZScUeKkBvK6pGZOLgQurUv3caWpRkrf6hlhmrKF0mz hnPG8Al4fVBfQJYasadNTqD8ngshdiY= X-Google-Smtp-Source: APXvYqy2vehQ4w1sNvQHIK58PnXeQOX8/aXLrDPAzBtZ2No4z0wtJ9+TVE5c0KF86+piralA7Sxtyg== X-Received: by 2002:a1c:ed10:: with SMTP id l16mr6511616wmh.118.1553092825868; Wed, 20 Mar 2019 07:40:25 -0700 (PDT) Received: from arch-late (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id c10sm2738646wrr.1.2019.03.20.07.40.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 07:40:25 -0700 (PDT) References: <20190319163622.30607-1-wsa+renesas@sang-engineering.com> User-agent: mu4e 1.0; emacs 27.0.50 From: Rui Miguel Silva To: Wolfram Sang Subject: Re: [PATCH 1/1] staging: media: imx: imx7-mipi-csis: simplify getting .driver_data In-reply-to: <20190319163622.30607-1-wsa+renesas@sang-engineering.com> Date: Wed, 20 Mar 2019 14:40:23 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_074028_268465_6EF276DF X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Fabio Estevam , Pengutronix Kernel Team , Greg Kroah-Hartman , Sascha Hauer , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, NXP Linux Team , Philipp Zabel , Steve Longerbeam , Mauro Carvalho Chehab , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wolfram, Thanks for the patch. On Tue 19 Mar 2019 at 16:36, Wolfram Sang wrote: > We should get 'driver_data' from 'struct device' directly. Going > via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > > Build tested only. buildbot is happy. > > drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c > b/drivers/staging/media/imx/imx7-mipi-csis.c > index 2ddcc42ab8ff..44569c63e4de 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -1039,8 +1039,7 @@ static int mipi_csis_probe(struct > platform_device *pdev) > > static int mipi_csis_pm_suspend(struct device *dev, bool > runtime) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev); > + struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev); > struct csi_state *state = mipi_sd_to_csis_state(mipi_sd); > int ret = 0; > > @@ -1064,8 +1063,7 @@ static int mipi_csis_pm_suspend(struct > device *dev, bool runtime) > > static int mipi_csis_pm_resume(struct device *dev, bool > runtime) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct v4l2_subdev *mipi_sd = platform_get_drvdata(pdev); > + struct v4l2_subdev *mipi_sd = dev_get_drvdata(dev); > struct csi_state *state = mipi_sd_to_csis_state(mipi_sd); > int ret = 0; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel