From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2833ACA0ED3 for ; Wed, 4 Sep 2024 14:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5R3FwcFISWrjuEPhMfG+SyE9ZdnbQEAewTHkSNEsJBI=; b=lA5NhY1pEf7ga8dQBzo9w15+XZ LW7amyyPk2eh/2ygd76+Y2bm2Ab/0HJ3xHu4Hc2IksJpKNz8khXFrOR+pa2w/V+5+pqmNghdEiUAf W9x/gPuDUITMS2EvILjyrcAHr7hGTn17UkYb3ay+Xrdqq1/fKhf74FzBKdeGbC3FVwdfp9DJHu3fL d91MwrJL4VUto4CvcM1+tja0UIhpumtnqWvbEasA8ldGNo1tWRzGXwH2+aIAjhiWu1xMa7CO11bGn n/ingbmwvpsghSZzs7ZdT6D0vMUoPpQFER+rf1s3kNTm+QY6WJg2mjY7xy/V4kvN0xEGYBVtDhyxA tSEBLewQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slqjx-00000004iR0-2Lrx; Wed, 04 Sep 2024 14:12:09 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slqgF-00000004hUI-24n7; Wed, 04 Sep 2024 14:08:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 18C565C555E; Wed, 4 Sep 2024 14:08:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7D5AC4CEC2; Wed, 4 Sep 2024 14:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725458898; bh=3q29PgcQ2KYbEcJauFATC6sMPQysTk+ZOJKpqoIZtgY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AK75AI5zKferY+Gqc5ROJeCW1lOZK5vJL8aQ/JR8oTEgAupYZwsDGQUNM7SR3Y8Nl aN9CARNwUf4lFYiqcGKxHQrxAzdvbLz4tZ9l6v6yfDHLyk+g3fync0P/DpELqdueM4 VqMSWSuAvvj0/qJ9sgI2KMTJg2u+GhpFtR+4VYOcDUJl+X8uAeJGzMvYMJmagGkhrT aPs+HGBEhsoWn2TVEc07oG3wm9e2f2TibwTGdhEdYRSHQ9tGL4go/lztRpysx7aMRX 4iUguOX+jtRsz9ymoOCQOdS2boyKOyySgJVZ/+MpzSTJTPobuvOMZW9uS/xHEOCHDr hvYU6RPff+xEg== From: Pratyush Yadav To: Miquel Raynal Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , , Matthias Brugger , AngeloGioacchino Del Regno , , Thomas Petazzoni Subject: Re: [PATCH next 2/2] mtd: rawnand: mtk: Fix init error path In-Reply-To: <20240826153019.67106-2-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Mon, 26 Aug 2024 17:30:19 +0200") References: <20240826153019.67106-1-miquel.raynal@bootlin.com> <20240826153019.67106-2-miquel.raynal@bootlin.com> Date: Wed, 04 Sep 2024 16:08:15 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_070819_670388_9EFD0EC0 X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 26 2024, Miquel Raynal wrote: > Reviewing a series converting the for_each_chil_of_node() loops into > their _scoped variants made me realize there was no cleanup of the > already registered NAND devices upon error which may leak memory on > systems with more than a chip when this error occurs. We should call the > _nand_chips_cleanup() function when this happens. > > Fixes: Fixes: 1d6b1e464950 ("mtd: mediatek: driver for MTK Smart Device") > Signed-off-by: Miquel Raynal Did a quick scan. Can't see anything (obvious) else being leaked on error paths. Reviewed-by: Pratyush Yadav -- Regards, Pratyush Yadav