From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: sunxi: Accept a greater rate when setting a parent clock
Date: Wed, 30 Mar 2016 19:47:40 +0200 [thread overview]
Message-ID: <mailman.14.1459361730.1636.linux-arm-kernel@lists.infradead.org> (raw)
The best rate of a clock may be a bit greater than the requested one.
In such a case, the rate setting from a child clock was rejected.
This patch fixes the problem searching a 'best rate' instead of
a 'fastest rate <= rate'.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
drivers/clk/sunxi/clk-factors.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/sunxi/clk-factors.c b/drivers/clk/sunxi/clk-factors.c
index ddefe96..c8e2f29 100644
--- a/drivers/clk/sunxi/clk-factors.c
+++ b/drivers/clk/sunxi/clk-factors.c
@@ -95,9 +95,10 @@ static int clk_factors_determine_rate(struct clk_hw *hw,
struct clk_factors *factors = to_clk_factors(hw);
struct clk_hw *parent, *best_parent = NULL;
int i, num_parents;
- unsigned long parent_rate, best = 0, child_rate, best_child_rate = 0;
+ unsigned long parent_rate, best = 0, child_rate, best_child_rate;
+ unsigned long d_rate, best_d_rate = ~0ul;
- /* find the parent that can help provide the fastest rate <= rate */
+ /* find the parent that can help provide the best rate */
num_parents = clk_hw_get_num_parents(hw);
for (i = 0; i < num_parents; i++) {
struct factors_request factors_req = {
@@ -116,10 +117,18 @@ static int clk_factors_determine_rate(struct clk_hw *hw,
factors->get_factors(&factors_req);
child_rate = factors_req.rate;
- if (child_rate <= req->rate && child_rate > best_child_rate) {
+ if (child_rate >= req->rate)
+ d_rate = child_rate - req->rate;
+ else
+ d_rate = req->rate - child_rate;
+
+ if (d_rate < best_d_rate) {
best_parent = parent;
best = parent_rate;
best_child_rate = child_rate;
+ if (d_rate == 0)
+ break;
+ best_d_rate = d_rate;
}
}
--
2.8.0
reply other threads:[~2016-03-30 17:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.14.1459361730.1636.linux-arm-kernel@lists.infradead.org \
--to=moinejf@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).