From: gdavis@mvista.com (George G. Davis)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix ARM11 MPCore OProfile breakage due to ARM patch 5901/2
Date: Fri, 5 Feb 2010 00:38:01 -0500 [thread overview]
Message-ID: <mailman.194.1265349378.2170.linux-arm-kernel@lists.infradead.org> (raw)
The recent "fe6c67f ARM: 5901/2: arm/oprofile: reserve the PMU when
starting" commit broke OProfile support on ARM11 MPCore targets by
adding a misplaced "} else {" clause in function em_start() which
results in a call to release_pmu() even though the PMU is in use
which in turn results in an oops while using OProfile. Removing
the stray else clause fixes the problem.
Signed-off-by: George G. Davis <gdavis@mvista.com>
---
arch/arm/oprofile/op_model_mpcore.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/oprofile/op_model_mpcore.c b/arch/arm/oprofile/op_model_mpcore.c
index f73ce87..0d4f099 100644
--- a/arch/arm/oprofile/op_model_mpcore.c
+++ b/arch/arm/oprofile/op_model_mpcore.c
@@ -246,7 +246,6 @@ static int em_start(void)
if (ret) {
arm11_release_interrupts(pmu_irqs->irqs,
pmu_irqs->num_irqs);
- } else {
release_pmu(pmu_irqs);
pmu_irqs = NULL;
}
--
Regards,
George
reply other threads:[~2010-02-05 5:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.194.1265349378.2170.linux-arm-kernel@lists.infradead.org \
--to=gdavis@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).