* [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
@ 2010-08-30 21:03 Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2010-08-30 21:03 UTC (permalink / raw)
To: linux-arm-kernel
Don't set TLB ops broadcasting on UP ARMv7. Looks like these bits
are also different on A8 and A9.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mm/proc-v7.S | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index 07fc660..51a063d 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -191,7 +191,8 @@ __v7_setup:
UP(mov r0, #(1 << 6)) @ fake it for UP
tst r0, #(1 << 6) @ SMP/nAMP mode enabled?
orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and
- mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting
+ SMP(mcreq p15, 0, r0, c1, c0, 1) @ TLB ops broadcasting
+ UP(nop) @ Don't enable on UP
#endif
adr r12, __v7_setup_stack @ the local stack
stmia r12, {r0-r5, r7, r9, r11, lr}
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
2010-09-02 16:16 ` Tony Lindgren
@ 2010-09-02 16:22 ` Tony Lindgren
2010-09-02 16:57 ` Russell King - ARM Linux
0 siblings, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2010-09-02 16:22 UTC (permalink / raw)
To: linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
2010-09-02 16:22 ` [PATCH 5/6] ARM: Don't set TLB ops broadcasting " Tony Lindgren
@ 2010-09-02 16:57 ` Russell King - ARM Linux
2010-09-02 17:21 ` Tony Lindgren
0 siblings, 1 reply; 7+ messages in thread
From: Russell King - ARM Linux @ 2010-09-02 16:57 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote:
> >From 8b22546af2ba9a0d96c2f419bfcec1f3c01a414d Mon Sep 17 00:00:00 2001
> From: Tony Lindgren <tony@atomide.com>
> Date: Mon, 30 Aug 2010 14:03:28 -0700
> Subject: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
>
> Don't set TLB ops broadcasting on UP ARMv7. Looks like these bits
> are also different on A8 and A9.
This is already taken care of.
> diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> index 07fc660..51a063d 100644
> --- a/arch/arm/mm/proc-v7.S
> +++ b/arch/arm/mm/proc-v7.S
> @@ -191,7 +191,8 @@ __v7_setup:
> UP(mov r0, #(1 << 6)) @ fake it for UP
If it's UP, we set r0 to 1 << 6, which...
> tst r0, #(1 << 6) @ SMP/nAMP mode enabled?
means this test produces a non-zero result.
> orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and
> - mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting
And therefore these instructions will not be executed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
2010-09-02 16:57 ` Russell King - ARM Linux
@ 2010-09-02 17:21 ` Tony Lindgren
2010-09-02 18:01 ` Russell King - ARM Linux
0 siblings, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2010-09-02 17:21 UTC (permalink / raw)
To: linux-arm-kernel
* Russell King - ARM Linux <linux@arm.linux.org.uk> [100902 09:50]:
> On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote:
> > >From 8b22546af2ba9a0d96c2f419bfcec1f3c01a414d Mon Sep 17 00:00:00 2001
> > From: Tony Lindgren <tony@atomide.com>
> > Date: Mon, 30 Aug 2010 14:03:28 -0700
> > Subject: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
> >
> > Don't set TLB ops broadcasting on UP ARMv7. Looks like these bits
> > are also different on A8 and A9.
>
> This is already taken care of.
>
> > diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> > index 07fc660..51a063d 100644
> > --- a/arch/arm/mm/proc-v7.S
> > +++ b/arch/arm/mm/proc-v7.S
> > @@ -191,7 +191,8 @@ __v7_setup:
> > UP(mov r0, #(1 << 6)) @ fake it for UP
>
> If it's UP, we set r0 to 1 << 6, which...
>
> > tst r0, #(1 << 6) @ SMP/nAMP mode enabled?
>
> means this test produces a non-zero result.
>
> > orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and
> > - mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting
>
> And therefore these instructions will not be executed.
AFAIK these bits are different for Cortex-A8 and A9, bit 6 is IBE on A8.
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
2010-09-02 17:21 ` Tony Lindgren
@ 2010-09-02 18:01 ` Russell King - ARM Linux
2010-09-02 18:13 ` Tony Lindgren
0 siblings, 1 reply; 7+ messages in thread
From: Russell King - ARM Linux @ 2010-09-02 18:01 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 02, 2010 at 10:21:33AM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [100902 09:50]:
> > On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote:
> > > >From 8b22546af2ba9a0d96c2f419bfcec1f3c01a414d Mon Sep 17 00:00:00 2001
> > > From: Tony Lindgren <tony@atomide.com>
> > > Date: Mon, 30 Aug 2010 14:03:28 -0700
> > > Subject: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
> > >
> > > Don't set TLB ops broadcasting on UP ARMv7. Looks like these bits
> > > are also different on A8 and A9.
> >
> > This is already taken care of.
> >
> > > diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> > > index 07fc660..51a063d 100644
> > > --- a/arch/arm/mm/proc-v7.S
> > > +++ b/arch/arm/mm/proc-v7.S
> > > @@ -191,7 +191,8 @@ __v7_setup:
> > > UP(mov r0, #(1 << 6)) @ fake it for UP
> >
> > If it's UP, we set r0 to 1 << 6, which...
> >
> > > tst r0, #(1 << 6) @ SMP/nAMP mode enabled?
> >
> > means this test produces a non-zero result.
> >
> > > orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and
> > > - mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting
> >
> > And therefore these instructions will not be executed.
>
> AFAIK these bits are different for Cortex-A8 and A9, bit 6 is IBE on A8.
So what?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
2010-09-02 18:01 ` Russell King - ARM Linux
@ 2010-09-02 18:13 ` Tony Lindgren
2010-09-02 18:18 ` Russell King - ARM Linux
0 siblings, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2010-09-02 18:13 UTC (permalink / raw)
To: linux-arm-kernel
* Russell King - ARM Linux <linux@arm.linux.org.uk> [100902 10:54]:
> On Thu, Sep 02, 2010 at 10:21:33AM -0700, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [100902 09:50]:
> > > On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote:
> > > > >From 8b22546af2ba9a0d96c2f419bfcec1f3c01a414d Mon Sep 17 00:00:00 2001
> > > > From: Tony Lindgren <tony@atomide.com>
> > > > Date: Mon, 30 Aug 2010 14:03:28 -0700
> > > > Subject: [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
> > > >
> > > > Don't set TLB ops broadcasting on UP ARMv7. Looks like these bits
> > > > are also different on A8 and A9.
> > >
> > > This is already taken care of.
> > >
> > > > diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> > > > index 07fc660..51a063d 100644
> > > > --- a/arch/arm/mm/proc-v7.S
> > > > +++ b/arch/arm/mm/proc-v7.S
> > > > @@ -191,7 +191,8 @@ __v7_setup:
> > > > UP(mov r0, #(1 << 6)) @ fake it for UP
> > >
> > > If it's UP, we set r0 to 1 << 6, which...
> > >
> > > > tst r0, #(1 << 6) @ SMP/nAMP mode enabled?
> > >
> > > means this test produces a non-zero result.
> > >
> > > > orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and
> > > > - mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting
> > >
> > > And therefore these instructions will not be executed.
> >
> > AFAIK these bits are different for Cortex-A8 and A9, bit 6 is IBE on A8.
>
> So what?
Ah right, sorry I should have looked more carefully. You're right, this patch
is no longer needed either.
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7
2010-09-02 18:13 ` Tony Lindgren
@ 2010-09-02 18:18 ` Russell King - ARM Linux
0 siblings, 0 replies; 7+ messages in thread
From: Russell King - ARM Linux @ 2010-09-02 18:18 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 02, 2010 at 11:13:17AM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [100902 10:54]:
> > On Thu, Sep 02, 2010 at 10:21:33AM -0700, Tony Lindgren wrote:
> > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [100902 09:50]:
> > > > On Thu, Sep 02, 2010 at 09:22:20AM -0700, Tony Lindgren wrote:
> > > > > diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> > > > > index 07fc660..51a063d 100644
> > > > > --- a/arch/arm/mm/proc-v7.S
> > > > > +++ b/arch/arm/mm/proc-v7.S
> > > > > @@ -191,7 +191,8 @@ __v7_setup:
> > > > > UP(mov r0, #(1 << 6)) @ fake it for UP
> > > >
> > > > If it's UP, we set r0 to 1 << 6, which...
> > > >
> > > > > tst r0, #(1 << 6) @ SMP/nAMP mode enabled?
> > > >
> > > > means this test produces a non-zero result.
> > > >
> > > > > orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and
> > > > > - mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting
> > > >
> > > > And therefore these instructions will not be executed.
> > >
> > > AFAIK these bits are different for Cortex-A8 and A9, bit 6 is IBE on A8.
> >
> > So what?
>
> Ah right, sorry I should have looked more carefully. You're right, this patch
> is no longer needed either.
Thanks - I was wondering whether I was missing something.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-09-02 18:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-30 21:03 [PATCH 5/6] ARM: Don't set TLB ops broadcasting on UP ARMv7 Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2010-08-17 14:12 [PATCH 0/4] Hacks to allow booting ARM SMP kernel " Tony Lindgren
2010-08-17 15:40 ` Russell King - ARM Linux
2010-08-19 7:38 ` Tony Lindgren
2010-08-19 9:38 ` Bryan Wu
2010-08-19 9:57 ` Tony Lindgren
2010-08-19 10:20 ` Russell King - ARM Linux
2010-08-20 12:06 ` Tony Lindgren
2010-08-30 22:55 ` Tony Lindgren
2010-09-02 13:36 ` Russell King - ARM Linux
2010-09-02 16:16 ` Tony Lindgren
2010-09-02 16:22 ` [PATCH 5/6] ARM: Don't set TLB ops broadcasting " Tony Lindgren
2010-09-02 16:57 ` Russell King - ARM Linux
2010-09-02 17:21 ` Tony Lindgren
2010-09-02 18:01 ` Russell King - ARM Linux
2010-09-02 18:13 ` Tony Lindgren
2010-09-02 18:18 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).