* [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices
@ 2011-07-21 21:03 Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2011-07-21 21:03 UTC (permalink / raw)
To: linux-arm-kernel
For converting from struct device to platform_device, and from
platform_device to struct omap_device, there are existing macros. Use
them instead of manual use of container_of().
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
arch/arm/plat-omap/mcbsp.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index 6c62af1..02199e8 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params);
#ifdef CONFIG_ARCH_OMAP3
static struct omap_device *find_omap_device_by_dev(struct device *dev)
{
- struct platform_device *pdev = container_of(dev,
- struct platform_device, dev);
- return container_of(pdev, struct omap_device, pdev);
+ struct platform_device *pdev = to_platform_device(dev);
+
+ return to_omap_device(pdev);
}
static void omap_st_on(struct omap_mcbsp *mcbsp)
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices
2011-07-21 23:52 [RFC/PATCH 0/7] decouple platform_device from omap_device Kevin Hilman
@ 2011-07-21 23:52 ` Kevin Hilman
2011-07-22 8:58 ` Felipe Balbi
2011-07-22 12:32 ` Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Kevin Hilman @ 2011-07-21 23:52 UTC (permalink / raw)
To: linux-arm-kernel
For converting from struct device to platform_device, and from
platform_device to struct device, there are existing macros. Use
them instead of manual use of container_of().
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
arch/arm/plat-omap/mcbsp.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index 6c62af1..02199e8 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params);
#ifdef CONFIG_ARCH_OMAP3
static struct omap_device *find_omap_device_by_dev(struct device *dev)
{
- struct platform_device *pdev = container_of(dev,
- struct platform_device, dev);
- return container_of(pdev, struct omap_device, pdev);
+ struct platform_device *pdev = to_platform_device(dev);
+
+ return to_omap_device(pdev);
}
static void omap_st_on(struct omap_mcbsp *mcbsp)
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices
2011-07-21 23:52 ` [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices Kevin Hilman
@ 2011-07-22 8:58 ` Felipe Balbi
2011-07-22 12:32 ` Sergei Shtylyov
1 sibling, 0 replies; 5+ messages in thread
From: Felipe Balbi @ 2011-07-22 8:58 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 21, 2011 at 04:52:14PM -0700, Kevin Hilman wrote:
> For converting from struct device to platform_device, and from
> platform_device to struct device, there are existing macros. Use
> them instead of manual use of container_of().
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> arch/arm/plat-omap/mcbsp.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index 6c62af1..02199e8 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params);
> #ifdef CONFIG_ARCH_OMAP3
> static struct omap_device *find_omap_device_by_dev(struct device *dev)
> {
> - struct platform_device *pdev = container_of(dev,
> - struct platform_device, dev);
> - return container_of(pdev, struct omap_device, pdev);
> + struct platform_device *pdev = to_platform_device(dev);
> +
> + return to_omap_device(pdev);
could simplify to:
return to_omap_device(to_platform_device(dev));
but it won't change much. Only decrease readability, probably.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110722/62086604/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices
2011-07-21 23:52 ` [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices Kevin Hilman
2011-07-22 8:58 ` Felipe Balbi
@ 2011-07-22 12:32 ` Sergei Shtylyov
2011-07-22 20:19 ` Kevin Hilman
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2011-07-22 12:32 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 22-07-2011 3:52, Kevin Hilman wrote:
> For converting from struct device to platform_device, and from
> platform_device to struct device,
You mean from platform_device to omap_device?
> there are existing macros. Use
> them instead of manual use of container_of().
> Signed-off-by: Kevin Hilman<khilman@ti.com>
> ---
> arch/arm/plat-omap/mcbsp.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index 6c62af1..02199e8 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params);
> #ifdef CONFIG_ARCH_OMAP3
> static struct omap_device *find_omap_device_by_dev(struct device *dev)
> {
> - struct platform_device *pdev = container_of(dev,
> - struct platform_device, dev);
> - return container_of(pdev, struct omap_device, pdev);
> + struct platform_device *pdev = to_platform_device(dev);
> +
> + return to_omap_device(pdev);
> }
>
> static void omap_st_on(struct omap_mcbsp *mcbsp)
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices
2011-07-22 12:32 ` Sergei Shtylyov
@ 2011-07-22 20:19 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2011-07-22 20:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
Sergei Shtylyov <sshtylyov@mvista.com> writes:
> On 22-07-2011 3:52, Kevin Hilman wrote:
>
>> For converting from struct device to platform_device, and from
>> platform_device to struct device,
>
> You mean from platform_device to omap_device?
>
Yes indeed, thanks. Updated patch below (only changelog changed)
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-22 20:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-21 21:03 [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2011-07-21 23:52 [RFC/PATCH 0/7] decouple platform_device from omap_device Kevin Hilman
2011-07-21 23:52 ` [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices Kevin Hilman
2011-07-22 8:58 ` Felipe Balbi
2011-07-22 12:32 ` Sergei Shtylyov
2011-07-22 20:19 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).