[PATCH 0/5] Miscellaneous s3c64xx fixes.

[PATCH 0/5] Miscellaneous s3c64xx fixes.

[Tomasz Figa]

This series attempts to fix some issues I approached when working
on the s3c64xx platform. See descriptions of individual patches for more
details on each one.

All the patches are based on v3.0 tag of Linus' tree.

Tomasz Figa (5):
  ARM: s3c64xx: PM: Mask and acknowledge all UART interrupts during
    core resume.
  ARM: s3c64xx: DMA: Use S3C64XX_SDMA_SEL register name instead of
    numeric address.
  ARM: s3c64xx: Save/restore S3C64XX_SDMA_SEL on suspend/resume.
  ARM: s3c64xx: Save/restore S3C64XX_MODEM_MIFPCON on suspend/resume to
    preserve LCD bypass state.
  ARM: s3c64xx: Add support for synchronous clock operation.

 arch/arm/mach-s3c64xx/clock.c                   |    8 +++++-
 arch/arm/mach-s3c64xx/dma.c                     |    2 +-
 arch/arm/mach-s3c64xx/include/mach/regs-clock.h |    4 +++
 arch/arm/mach-s3c64xx/include/mach/regs-sys.h   |    2 +
 arch/arm/mach-s3c64xx/pm.c                      |   30 
+++++++++++++++++++++++
 5 files changed, 44 insertions(+), 2 deletions(-)

-- 
1.7.6

[PATCH 0/5] Miscellaneous s3c64xx fixes.

[Tomasz Figa]

[PATCH 0/5] Miscellaneous s3c64xx fixes.

[Tomasz Figa]

Anyone?

On Friday 29 of July 2011 at 17:50:57, Tomasz Figa wrote:
> From c985e14a4fc5c7970d7f6c2fde6d214217214688 Mon Sep 17 00:00:00 2001
> From: Tomasz Figa <tomasz.figa@gmail.com>
> Date: Fri, 29 Jul 2011 16:50:16 +0200
> Subject: [PATCH 0/5] Miscellaneous s3c64xx fixes.
> 
> This series attempts to fix some issues I approached when working
> on the s3c64xx platform. See descriptions of individual patches for more
> details on each one.
> 
> All the patches are based on v3.0 tag of Linus' tree.
> 
> Tomasz Figa (5):
>   ARM: s3c64xx: PM: Mask and acknowledge all UART interrupts during
>     core resume.
>   ARM: s3c64xx: DMA: Use S3C64XX_SDMA_SEL register name instead of
>     numeric address.
>   ARM: s3c64xx: Save/restore S3C64XX_SDMA_SEL on suspend/resume.
>   ARM: s3c64xx: Save/restore S3C64XX_MODEM_MIFPCON on suspend/resume to
>     preserve LCD bypass state.
>   ARM: s3c64xx: Add support for synchronous clock operation.
> 
>  arch/arm/mach-s3c64xx/clock.c                   |    8 +++++-
>  arch/arm/mach-s3c64xx/dma.c                     |    2 +-
>  arch/arm/mach-s3c64xx/include/mach/regs-clock.h |    4 +++
>  arch/arm/mach-s3c64xx/include/mach/regs-sys.h   |    2 +
>  arch/arm/mach-s3c64xx/pm.c                      |   30 
> +++++++++++++++++++++++
>  5 files changed, 44 insertions(+), 2 deletions(-)
> 
> 

[PATCH 0/5] Miscellaneous s3c64xx fixes.

[Kukjin Kim]

Tomasz Figa wrote:
> 
> Anyone?
> 
Hi Tomasz Figa,

Will be on this in the next week...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> On Friday 29 of July 2011 at 17:50:57, Tomasz Figa wrote:
> > From c985e14a4fc5c7970d7f6c2fde6d214217214688 Mon Sep 17 00:00:00 2001
> > From: Tomasz Figa <tomasz.figa@gmail.com>
> > Date: Fri, 29 Jul 2011 16:50:16 +0200
> > Subject: [PATCH 0/5] Miscellaneous s3c64xx fixes.
> >
> > This series attempts to fix some issues I approached when working
> > on the s3c64xx platform. See descriptions of individual patches for more
> > details on each one.
> >
> > All the patches are based on v3.0 tag of Linus' tree.
> >
> > Tomasz Figa (5):
> >   ARM: s3c64xx: PM: Mask and acknowledge all UART interrupts during
> >     core resume.
> >   ARM: s3c64xx: DMA: Use S3C64XX_SDMA_SEL register name instead of
> >     numeric address.
> >   ARM: s3c64xx: Save/restore S3C64XX_SDMA_SEL on suspend/resume.
> >   ARM: s3c64xx: Save/restore S3C64XX_MODEM_MIFPCON on
> suspend/resume to
> >     preserve LCD bypass state.
> >   ARM: s3c64xx: Add support for synchronous clock operation.
> >
> >  arch/arm/mach-s3c64xx/clock.c                   |    8 +++++-
> >  arch/arm/mach-s3c64xx/dma.c                     |    2 +-
> >  arch/arm/mach-s3c64xx/include/mach/regs-clock.h |    4 +++
> >  arch/arm/mach-s3c64xx/include/mach/regs-sys.h   |    2 +
> >  arch/arm/mach-s3c64xx/pm.c                      |   30
> > +++++++++++++++++++++++
> >  5 files changed, 44 insertions(+), 2 deletions(-)

[PATCH 0/5] Miscellaneous s3c64xx fixes.

[Tomasz Figa]

On Saturday 13 of August 2011 at 13:15:36, Kukjin Kim wrote:
> Tomasz Figa wrote:
> > 
> > Anyone?
> > 
> Hi Tomasz Figa,
> 
> Will be on this in the next week...
> 
> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 

Thanks a lot. I have plenty of other S3C64xx patches to be submitted, but they 
are more feature additions not fixes, so I am waiting for these fixes to be 
reviewed first.

Best regards,
Tom

[PATCH 0/5] Miscellaneous s3c64xx fixes.

[Kukjin Kim]

Tomasz Figa wrote:
> 
> On Saturday 13 of August 2011 at 13:15:36, Kukjin Kim wrote:
> > Tomasz Figa wrote:
> > >
> > > Anyone?
> > >
> > Hi Tomasz Figa,
> >
> > Will be on this in the next week...
> >
> > Thanks.
> >
> > Best regards,
> > Kgene.
> > --
> > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> > SW Solution Development Team, Samsung Electronics Co., Ltd.
> >
> 
> Thanks a lot. I have plenty of other S3C64xx patches to be submitted, but
they
> are more feature additions not fixes, so I am waiting for these fixes to
be
> reviewed first.
> 
Hi,

Firstly, you have to re-submit whole series with your 'sign'. It is very
important.

And 2nd, 3rd and 4th patches look ok to me except missing your sign even
though I think, secure DMA mode should be setting in boot loader with trust
zone...

Please refer to my review on 5th patch.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 0/5] Miscellaneous s3c64xx fixes.

[Tomasz Figa]

Hi,

On Friday 19 of August 2011 at 14:24:09, Kukjin Kim wrote:
> Tomasz Figa wrote:
> > 
> > On Saturday 13 of August 2011 at 13:15:36, Kukjin Kim wrote:
> > > Tomasz Figa wrote:
> > > >
> > > > Anyone?
> > > >
> > > Hi Tomasz Figa,
> > >
> > > Will be on this in the next week...
> > >
> > > Thanks.
> > >
> > > Best regards,
> > > Kgene.
> > > --
> > > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> > > SW Solution Development Team, Samsung Electronics Co., Ltd.
> > >
> > 
> > Thanks a lot. I have plenty of other S3C64xx patches to be submitted, but
> they
> > are more feature additions not fixes, so I am waiting for these fixes to
> be
> > reviewed first.
> > 
> Hi,
> 
> Firstly, you have to re-submit whole series with your 'sign'. It is very
> important.

Yes, I know, sorry for this. I must have missed a switch of git format-patch.
I will resend all the patches (excluding the dropped one).

> And 2nd, 3rd and 4th patches look ok to me except missing your sign even
> though I think, secure DMA mode should be setting in boot loader with trust
> zone...

I agree, that ideally this should be done by a boot loader, but since we don't
support Secure DMA at the moment, all the peripherals have to be forced into
normal insecure operation for the drivers using DMA to work correctly.

> Please refer to my review on 5th patch.

Done. I will address all your comments.

> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 

Best regards,
Tom