From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] clk: core: Force setting the phase delay when no change
Date: Wed, 24 Aug 2016 08:32:51 +0200 [thread overview]
Message-ID: <mailman.42.1472030557.1636.linux-arm-kernel@lists.infradead.org> (raw)
This patch reverts the commit 023bd7166be0595d18220dfd5c9765b3970f6ef3
(clk: skip unnecessary set_phase if nothing to do), fixing two
problems:
- in some SoCs, the hardware phase delay depends on the rate ratio of
the clock and its parent. So, changing this ratio may imply to set
new hardware values, even if the logical delay is the same.
- when the delay was the same as previously, an error was returned.
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
resend:
- send to the clock maintainers (asked by Maxime Ripard)
- change the comment adding the reference to the reverted commit
---
drivers/clk/clk.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 71cc567..7e8576e 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1908,10 +1908,6 @@ int clk_set_phase(struct clk *clk, int degrees)
clk_prepare_lock();
- /* bail early if nothing to do */
- if (degrees == clk->core->phase)
- goto out;
-
trace_clk_set_phase(clk->core, degrees);
if (clk->core->ops->set_phase)
@@ -1922,7 +1918,6 @@ int clk_set_phase(struct clk *clk, int degrees)
if (!ret)
clk->core->phase = degrees;
-out:
clk_prepare_unlock();
return ret;
--
2.9.3
next reply other threads:[~2016-08-24 6:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 6:32 Jean-Francois Moine [this message]
[not found] <20160824092212.D088561C49@smtp.codeaurora.org>
2016-08-30 21:51 ` [PATCH RESEND] clk: core: Force setting the phase delay when no change Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mailman.42.1472030557.1636.linux-arm-kernel@lists.infradead.org \
--to=moinejf@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).