From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EDC1C4345F for ; Fri, 3 May 2024 09:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pZqOVCujc6cBjFlR/yeiN+mQMSCMLww4TWaW0wwpsM8=; b=K00qxMxaeM6oak QXMWdrUphTG7d/NoT7y7ZNBIkP7dVeKsMT8ZibLcwrdMAK57EGz0aIcOqmKRF6N8XikF8dzOSA/ev xGDGD2Bl5CQvcZPJidTWlUb/9gL/aUS0Df9cmYOLzut3IxkA/mez1RXOb7FPm0J+aqd9fcERcCTgi rOSldPTym433BxicTJ0vuYEqQYXia3YHUihhCvZtm9OaDwHa4QTI91EnKvTDkzwWOpFKOblsOa+7a A9+AYPAYoS70cWX1/hKREz7Uu9B8AIJWMD6gFsIr0VDVusQG/s2x0CUVMwbJXEkH8Tm5+XyZkWGqO ZgHLDWeq/jpYqP88U09A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2pSp-0000000Fuej-0Ewt; Fri, 03 May 2024 09:44:23 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2pSm-0000000Fud8-14HE for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2024 09:44:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 993A3CE0AB3; Fri, 3 May 2024 09:44:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97DE5C116B1; Fri, 3 May 2024 09:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714729457; bh=DWh57NqU0/01iRmPDMXy/K+8zd+9eqAkFxqVGj8kOtg=; h=From:To:Subject:In-Reply-To:References:Date:From; b=Ii0ghA/YVJREs60D0+Ol82Qa7xqhrfxI3ebnu+ap6H+s/XvbpHlpdyZcjGT9yU1xj 0ouwwgj1ekvfQGDee3NfIQtTuS3YJgBm7e6diV5hBWGkZEp24JjmwuMEqErTDWEpHg R1j6rtZtycwh6UT7gMDURnHQNCYQYs3adtjU6f0HpfIN143LXGTXM+UNurA40g9tH5 2r6/SGQs3dXHRXzyFx7oQ8yTxniTjxPN0asI9OF0vtqPAJPsEXHHUwPKB/uvzCKsvL 7XYqwW8hiJ5H2sMZaRIDEKVDY2jeaFXHiJhp/OB5S0O9QN7wP1/Qxzf5PcNAyIiZy4 yYz3+ALAyP2tQ== From: Puranjay Mohan To: Anshuman Khandual , Catalin Marinas , Will Deacon , Sumit Garg , Stephen Boyd , Douglas Anderson , "Peter Zijlstra (Intel)" , Thomas Gleixner , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 1/2] arm64/arch_timer: include In-Reply-To: <7008cd0c-5b65-4289-9015-434cbe3d7e21@arm.com> References: <20240502123449.2690-1-puranjay@kernel.org> <7008cd0c-5b65-4289-9015-434cbe3d7e21@arm.com> Date: Fri, 03 May 2024 09:44:14 +0000 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_024420_495289_9E52DB56 X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Anshuman Khandual writes: > On 5/2/24 18:04, Puranjay Mohan wrote: >> arch_timer.h includes linux/smp.h to use DEFINE_PER_CPU() and it works >> because smp.h includes percpu.h. The next commit will remove percpu.h >> from smp.h and it will break this usage. >> >> Explicitly include percpu.h and remove smp.h > > But this particular change does not seem to be necessary for changing > raw_smp_processor_id() as current_thread_info()->cpu being done in the > later patch ? You might still leave header inclusion in > arch/arm64/include/asm/smp.h while dropping the per cpu cpu_number ? commit 57c82954e77f ("arm64: make cpu number a percpu variable") created this percpu variable and included in Now we are removing the percpu variable cpu_number from smp.h, so there is no need to keep percpu.h in smp.h I feel users of DECLARE_PER_CPU_[...], etc. should include percpu.h and not smp.h as it makes reading the code more easier and can thwart build issues in the future, when headers are changed. Thanks, Puranjay _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel