From: mroberto@cpti.cetuc.puc-rio.br (Marcelo Jimenez)
To: linux-arm-kernel@lists.infradead.org
Subject: Suspicious compilation warning
Date: Tue, 4 May 2010 14:35:50 -0300 [thread overview]
Message-ID: <n2gcecb6d8f1005041035w51dac3c8ke829a4ae8bf7f408@mail.gmail.com> (raw)
In-Reply-To: <20100420230719.GB1432@n2100.arm.linux.org.uk>
Hi,
On Tue, Apr 20, 2010 at 20:07, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
>
> Well, it'll be about this number on everything using sparsemem extreme:
>
> #define SECTIONS_PER_ROOT ? ? ? (PAGE_SIZE / sizeof (struct mem_section))
>
> and with only 32 sections, this is going to give a NR_SECTION_ROOTS value
> of zero. ?I think the calculation of NR_SECTIONS_ROOTS is wrong.
>
> #define NR_SECTION_ROOTS ? ? ? ?(NR_MEM_SECTIONS / SECTIONS_PER_ROOT)
>
> Clearly if we have 1 mem section, we want to have one section root, so
> I think this division should round up any fractional part, thusly:
>
> #define NR_SECTION_ROOTS ? ? ? ?((NR_MEM_SECTIONS + SECTIONS_PER_ROOT - 1) / SECTIONS_PER_ROOT)
Seems correct to me, Is there any idea when this gets committed?
Regards,
Marcelo.
next prev parent reply other threads:[~2010-05-04 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 23:27 Suspicious compilation warning Marcelo Jimenez
2010-04-20 22:51 ` Andrew Morton
2010-04-20 23:07 ` Russell King - ARM Linux
2010-05-04 17:35 ` Marcelo Jimenez [this message]
2010-05-04 17:45 ` Russell King - ARM Linux
2010-05-04 18:16 ` Marcelo Jimenez
2010-05-05 10:06 ` Sergei Shtylyov
2010-05-06 1:24 ` Kyungmin Park
2010-05-06 13:24 ` Marcelo Jimenez
2010-05-10 15:40 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n2gcecb6d8f1005041035w51dac3c8ke829a4ae8bf7f408@mail.gmail.com \
--to=mroberto@cpti.cetuc.puc-rio.br \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).