linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] PL330: Add common core driver
Date: Sat, 24 Apr 2010 08:20:48 +0900	[thread overview]
Message-ID: <n2y1b68c6791004231620lcd670271u3a9d33bb52c10e37@mail.gmail.com> (raw)
In-Reply-To: <j2x63386a3d1004231449ta90046b5pc29622b58a87b99a@mail.gmail.com>

On Sat, Apr 24, 2010 at 6:49 AM, Linus Walleij
<linus.ml.walleij@gmail.com> wrote:
> 2010/4/21 ?<jassisinghbrar@gmail.com>:
>
>> PL330 is a configurable DMA controller PrimeCell device.
>> The register map of the device is well defined.
>> The configuration of a particular implementation can be
>> read from the six configuration registers CR0-4,Dn.
>
> I think this looks better for every iteration and is definately ripe
> for merge, so FWIW:
> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Thanks.

>> The exported interface should be sufficient to implement
>> a driver for any DMA API.
>
> Will you make an attempt at doing this in time for the next
> merge window as well? That would be perfect.
Actually I said "any DMA API" i.e, some platform, like S3C,
may choose to implement their own API.

You mean the DMA engine driver for PL330, right?
Since Joonyoung's driver was pre-empted by these patches,
he might want to re-write parts of his driver for this backend.
If he doesn't show any interest in a few days, I'll do it.

Btw, I think that driver should be divided in two files
drivers/dma/api-pl330.c with common code and
drivers/dma/<soc>-pl330.c for platform specific stuff like IRQ,
registers base mapping and other quirks(if any). Any opinions?

  reply	other threads:[~2010-04-23 23:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21  7:27 [PATCH 1/7] PL330: Add common core driver jassisinghbrar at gmail.com
2010-04-23 21:49 ` Linus Walleij
2010-04-23 23:20   ` jassi brar [this message]
2010-04-25  1:59     ` Linus Walleij
2010-04-26  4:56       ` Ben Dooks
2010-04-26  6:41         ` jassi brar
2010-04-26  4:54 ` Ben Dooks
2010-04-26  6:20   ` jassi brar
2010-04-26  7:09     ` [PATCH 1/7] PL330: Add common core driver\ Ben Dooks
2010-05-01 21:01       ` Dan Williams
2010-05-02  0:23         ` jassi brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=n2y1b68c6791004231620lcd670271u3a9d33bb52c10e37@mail.gmail.com \
    --to=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).