linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: martinwguy@gmail.com (Martin Guy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] spi: implemented driver for Cirrus EP93xx SPI controller
Date: Sat, 24 Apr 2010 19:14:43 +0100	[thread overview]
Message-ID: <p2h56d259a01004241114qb1b1815em9657e5a857a9d4ee@mail.gmail.com> (raw)
In-Reply-To: <e96939d18bcbfb7a28ba4a925d7788884566db8c.1271774845.git.mika.westerberg@iki.fi>

Hi, another little fix:

EP93xx User's Manual -> Synchronous Serial Port -> Registers

SSPIIR description:
"Read Only
Note: A write to this register clears the receive overrun interrupt,
regardless of the data
      value written."

It doesn't affect the RIS/TIS ones, which are caused by the state of the device.

so

static irqreturn_t ep93xx_spi_interrupt(int irq, void *dev_id)
{
...
        if (!(irq_status & (SSPIIR_RORIS | SSPIIR_TIS | SSPIIR_RIS)))
                return IRQ_NONE; /* not for us */

-       /* clear the interrupt */
-       ep93xx_spi_write_u8(espi, SSPICR, 0);

        /*
         * If we got ROR (receive overrun) interrupt we know that something is
         * wrong. Just abort the message.
         */
        if (unlikely(irq_status & SSPIIR_RORIS)) {
+               /* clear the overrun interrupt */
+               ep93xx_spi_write_u8(espi, SSPICR, 0);
                dev_warn(&espi->pdev->dev,
                         "receive overrun, aborting the message\n");
                espi->current_msg->status = -EIO;
        } else {

  parent reply	other threads:[~2010-04-24 18:14 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 15:11 [PATCH v4 0/2] spi: driver for Cirrus EP93xx SPI controller Mika Westerberg
2010-04-20 15:11 ` [PATCH v4 1/2] spi: implemented " Mika Westerberg
2010-04-20 17:24   ` H Hartley Sweeten
2010-04-21  7:16     ` Mika Westerberg
2010-04-21 16:47       ` H Hartley Sweeten
2010-04-21 16:54         ` Mika Westerberg
2010-04-22  2:47           ` H Hartley Sweeten
2010-04-22  5:53             ` Mika Westerberg
2010-04-22 14:11             ` Martin Guy
2010-04-22 14:28             ` Martin Guy
2010-04-22 17:39               ` H Hartley Sweeten
2010-04-22 20:19                 ` Martin Guy
2010-04-20 22:16   ` H Hartley Sweeten
2010-04-20 23:54     ` Martin Guy
2010-04-21  0:11       ` H Hartley Sweeten
2010-04-21  0:43         ` [spi-devel-general] " H Hartley Sweeten
2010-04-21  1:10         ` Martin Guy
2010-04-21  1:52           ` H Hartley Sweeten
2010-04-21  7:00             ` Mika Westerberg
2010-04-21 10:46             ` Mika Westerberg
2010-04-21 18:00               ` H Hartley Sweeten
2010-04-22  5:45                 ` Mika Westerberg
2010-04-22 21:29                   ` Ryan Mallon
2010-04-22 17:55                 ` Mika Westerberg
2010-04-22 20:43                   ` H Hartley Sweeten
2010-04-23  5:20                     ` Mika Westerberg
2010-04-23 17:24                       ` H Hartley Sweeten
2010-04-23 23:01                         ` [spi-devel-general] " H Hartley Sweeten
2010-04-25  9:29                           ` Martin Guy
2010-04-25  9:38                             ` Martin Guy
2010-04-25 20:25                               ` H Hartley Sweeten
2010-04-26 10:02                                 ` Mika Westerberg
2010-04-26 16:54                                   ` H Hartley Sweeten
2010-04-26 10:09                                 ` Mika Westerberg
2010-04-26 14:35                                 ` Martin Guy
2010-04-26 17:05                                   ` H Hartley Sweeten
2010-04-29 18:30           ` Mika Westerberg
2010-04-21  6:37     ` Mika Westerberg
2010-04-21 17:08       ` H Hartley Sweeten
2010-04-24 18:14   ` Martin Guy [this message]
2010-04-25 19:55     ` H Hartley Sweeten
2010-04-26 10:34       ` Mika Westerberg
2010-04-26 12:58       ` Martin Guy
2010-04-20 15:11 ` [PATCH v4 2/2] ep93xx: SPI driver platform support code Mika Westerberg
2010-04-20 16:35   ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p2h56d259a01004241114qb1b1815em9657e5a857a9d4ee@mail.gmail.com \
    --to=martinwguy@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).