Re: [PATCH v5 0/6] Add Rockchip RK3576 PWM Support Through MFPWM

Uwe Kleine-König
2026-04-24T10:43:40Z

[-- Attachment #1: Type: text/plain, Size: 2784 bytes --]

[Dropped Jonas Karlman from Cc:, their email bounced for me in the past]

Hello Nicolas,

On Wed, Apr 22, 2026 at 01:31:14PM +0200, Nicolas Frattaroli wrote:
> On Tuesday, 21 April 2026 17:56:56 Central European Summer Time Jonathan Cameron wrote:
> > On Mon, 20 Apr 2026 15:52:37 +0200
> > Nicolas Frattaroli <nicolas.frattaroli@collabora.com> wrote:
> >
> > > This series introduces support for some of the functions of the new PWM
> > > silicon found on Rockchip's RK3576 SoC. Due to the wide range of
> > > functionalities offered by it, including many parts which this series'
> > > first iteration does not attempt to implement for now. The drivers are
> > > modelled as an MFD, with no leakage of the MFD-ness into the binding, as
> > > it's a Linux implementation detail.
> >
> > Just thought I'd point out that as this includes the linux-iio
> > list sashiko took a look at it. Quite a few things and at least
> > the first one I looked at was valid (a dereference before a validity
> > check)
> >
> > https://sashiko.dev/#/patchset/20260420-rk3576-pwm-v5-0-ae7cfbbe5427%40collabora.com
> >
> > Whilst this tool does generate some false positives, it also finds
> > quite a few things it seems us humans fail to spot.
> >
> > Jonathan
> >
>
> While I'm not entirely opposed to this, I do think reviews should happen
> on-list when possible. Sashiko is a Google service, so it has about a 50%
> chance of still being around in 2 years time. One of the benefits of the
> kernel development workflow is that discussion going back decades is still
> accessible.

I mostly agree to your point. A possibility that I would consider
compatible with on-list review is looking through what Sashiko found and
address that on the list. Something like
https://lore.kernel.org/all/20260420204647.1713944-2-u.kleine-koenig@baylibre.com/

> The reason why these aren't posted to list goes into the other thing
> that I currently am not stoked about, which is that I'd have to act as
> a filter for a Bring-Your-Own-Brain noise generator to pick out the
> parts that aren't convincing lies.

I didn't look through the complete feedback, but the part that I looked
at (I'd say the rough half) seems to be legitimate.

I'm also have reservations about AI, but my (little) experience with
this one seems to show that it's in the better half of the scale between
helpful and useless time consumer. So when I come around to review your
series I will for sure look through their feedback in more detail. That
means that if I'm too slow for you, looking through the feedback
yourself and addressing that (or deciding against it) might be a good
way to spend the waiting time and maybe even making it easier for me.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]