From: jassisinghbrar@gmail.com (jassi brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] PL330: Add common core driver
Date: Mon, 26 Apr 2010 15:41:19 +0900 [thread overview]
Message-ID: <q2q1b68c6791004252341k51da90d0xfaf2850b90d7c46c@mail.gmail.com> (raw)
In-Reply-To: <20100426045627.GI28105@trinity.fluff.org>
On Mon, Apr 26, 2010 at 1:56 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Sun, Apr 25, 2010 at 03:59:26AM +0200, Linus Walleij wrote:
>> 2010/4/24 jassi brar <jassisinghbrar@gmail.com>:
>> > Btw, I think that driver should be divided in two files
>> > drivers/dma/api-pl330.c with common code and
>> > drivers/dma/<soc>-pl330.c for platform specific stuff like IRQ,
>> > registers base mapping and other quirks(if any). Any opinions?
>
> Possibly, but I think it may be better to pass these things via platform
> device for registers and irqs, and platform data for the quirks.
Some platforms implement just one i/f either secure or non-secure, others
might implement both. Having a separate file for platforms would make
it possible to switch between secure and non-secure i/fs acc to the needs
of the platform. Similarly for the DMAC reset mechanism.
Also, I am afraid, managing quirks in common code might get trickier over time.
next prev parent reply other threads:[~2010-04-26 6:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 7:27 [PATCH 1/7] PL330: Add common core driver jassisinghbrar at gmail.com
2010-04-23 21:49 ` Linus Walleij
2010-04-23 23:20 ` jassi brar
2010-04-25 1:59 ` Linus Walleij
2010-04-26 4:56 ` Ben Dooks
2010-04-26 6:41 ` jassi brar [this message]
2010-04-26 4:54 ` Ben Dooks
2010-04-26 6:20 ` jassi brar
2010-04-26 7:09 ` [PATCH 1/7] PL330: Add common core driver\ Ben Dooks
2010-05-01 21:01 ` Dan Williams
2010-05-02 0:23 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=q2q1b68c6791004252341k51da90d0xfaf2850b90d7c46c@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).