From: timur.tabi@gmail.com (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 10/10] mx5: Add MX53 EVK board support
Date: Mon, 19 Apr 2010 15:53:01 -0500 [thread overview]
Message-ID: <r2jed82fe3e1004191353yc1173cdai71204b1aa38d89a6@mail.gmail.com> (raw)
In-Reply-To: <DE2504B3A515524BBE6934369EFDC0DA0937E409@az33exm20.fsl.freescale.net>
On Mon, Apr 19, 2010 at 3:47 PM, Herring Robert-RA7055
<ra7055@freescale.com> wrote:
>> You forgot to run checkpatch.pl. ?C++ comments are not allowed.
>
> Yes I know. I'm only soliciting comments on the way I have structured adding MX53 to MX51 codebase.
Ok.
>> How about:
>>
>> #define mxc_init_imx_uart() do { } while (0)
>
> Just following existing code style in board-mx51_babbage.c.
I understand, but I believe the consensus for general kernel
development is to use "#define .. do while(0)" to represent a no-op
function.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2010-04-19 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 19:35 [RFC PATCH 10/10] mx5: Add MX53 EVK board support Rob Herring
2010-04-16 22:15 ` Fabio Estevam
2010-04-19 13:33 ` Herring Robert-RA7055
2010-04-19 13:55 ` Amit Kucheria
2010-04-17 16:00 ` Xianghua Xiao
2010-04-19 20:40 ` Timur Tabi
2010-04-19 20:47 ` Herring Robert-RA7055
2010-04-19 20:53 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r2jed82fe3e1004191353yc1173cdai71204b1aa38d89a6@mail.gmail.com \
--to=timur.tabi@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).