[PATCH] ARM: Declare __copy_to_user_std as a function using ENDPROC

[PATCH] ARM: Declare __copy_to_user_std as a function using ENDPROC

[Catalin Marinas]

This is needed for Thumb-2 kernel builds, otherwise the compiler
generates branches into ARM mode to this function.

Reported-by: Kyungmin Park <kmpark@infradead.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
 arch/arm/lib/copy_to_user.S |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/lib/copy_to_user.S b/arch/arm/lib/copy_to_user.S
index 1a71e15..5941fbc 100644
--- a/arch/arm/lib/copy_to_user.S
+++ b/arch/arm/lib/copy_to_user.S
@@ -93,6 +93,7 @@ WEAK(__copy_to_user)
 #include "copy_template.S"
 
 ENDPROC(__copy_to_user)
+ENDPROC(__copy_to_user_std)
 
 	.section .fixup,"ax"
 	.align 0

[PATCH] ARM: Declare __copy_to_user_std as a function using ENDPROC

[Nicolas Pitre]

On Thu, 6 May 2010, Catalin Marinas wrote:

> This is needed for Thumb-2 kernel builds, otherwise the compiler
> generates branches into ARM mode to this function.
> 
> Reported-by: Kyungmin Park <kmpark@infradead.org>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

You need to do the same with __clear_user_std as well.  With that change 
added:

Acked-by: Nicolas Pitre <nico@fluxnic.net>




> ---
>  arch/arm/lib/copy_to_user.S |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/lib/copy_to_user.S b/arch/arm/lib/copy_to_user.S
> index 1a71e15..5941fbc 100644
> --- a/arch/arm/lib/copy_to_user.S
> +++ b/arch/arm/lib/copy_to_user.S
> @@ -93,6 +93,7 @@ WEAK(__copy_to_user)
>  #include "copy_template.S"
>  
>  ENDPROC(__copy_to_user)
> +ENDPROC(__copy_to_user_std)
>  
>  	.section .fixup,"ax"
>  	.align 0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

[PATCH] ARM: Declare __copy_to_user_std as a function using ENDPROC

[Kyungmin Park]

Tested-by: Kyungmin Park <kyungmin.park@samsung.com>

On Fri, May 7, 2010 at 2:35 AM, Nicolas Pitre <nico@fluxnic.net> wrote:
> On Thu, 6 May 2010, Catalin Marinas wrote:
>
>> This is needed for Thumb-2 kernel builds, otherwise the compiler
>> generates branches into ARM mode to this function.
>>
>> Reported-by: Kyungmin Park <kmpark@infradead.org>
>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>
> You need to do the same with __clear_user_std as well. ?With that change
> added:
>
> Acked-by: Nicolas Pitre <nico@fluxnic.net>
>
>
>
>
>> ---
>> ?arch/arm/lib/copy_to_user.S | ? ?1 +
>> ?1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/lib/copy_to_user.S b/arch/arm/lib/copy_to_user.S
>> index 1a71e15..5941fbc 100644
>> --- a/arch/arm/lib/copy_to_user.S
>> +++ b/arch/arm/lib/copy_to_user.S
>> @@ -93,6 +93,7 @@ WEAK(__copy_to_user)
>> ?#include "copy_template.S"
>>
>> ?ENDPROC(__copy_to_user)
>> +ENDPROC(__copy_to_user_std)
>>
>> ? ? ? .section .fixup,"ax"
>> ? ? ? .align 0
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>