From: Takashi Iwai <tiwai@suse.de>
To: Sriram Periyasamy <sriram.oqensourz@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com,
Jeff Chang <richtek.jeff.chang@gmail.com>,
broonie@kernel.org, matthias.bgg@gmail.com,
jeff_chang@richtek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH v4] ASoC: Add MediaTek MT6660 Speaker Amp Driver
Date: Thu, 09 Jan 2020 19:57:34 +0100 [thread overview]
Message-ID: <s5h36comp9d.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200109171833.GA2709@sriram-VirtualBox>
On Thu, 09 Jan 2020 18:18:36 +0100,
Sriram Periyasamy wrote:
>
> On Tue, Jan 07, 2020 at 11:09:05AM +0800, Jeff Chang wrote:
> > From: Jeff Chang <jeff_chang@richtek.com>
> >
> > The MT6660 is a boosted BTL class-D amplifier with V/I sensing.
> > A built-in DC-DC step-up converter is used to provide efficient
> > power for class-D amplifier with multi-level class-G operation.
> > The digital audio interface supports I2S, left-justified,
> > right-justified, TDM and DSP A/B format for audio in with a data
> > out used for chip information like voltage sense and current
> > sense, which are able to be monitored via DATAO through proper
> >
> > diff --git a/sound/soc/codecs/mt6660.c b/sound/soc/codecs/mt6660.c
> > new file mode 100644
> > index 0000000..b8fc53b
> > --- /dev/null
> > +++ b/sound/soc/codecs/mt6660.c
> > @@ -0,0 +1,628 @@
>
> > +
> > +struct codec_reg_val {
> > + u32 addr;
> > + u32 mask;
> > + u32 data;
> > +};
>
> packed structures could have been better.
It depends. Packing may break alignment and the performance may
suffer from it. So, in general, __packed is recommended when the size
matters (e.g. lots of objects / arrays are created) or it's about ABI
that needs the fixed consistent size.
thanks,
Takashi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-09 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 3:09 [PATCH v4] ASoC: Add MediaTek MT6660 Speaker Amp Driver Jeff Chang
2020-01-09 17:18 ` [alsa-devel] " Sriram Periyasamy
2020-01-09 18:57 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h36comp9d.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeff_chang@richtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=richtek.jeff.chang@gmail.com \
--cc=sriram.oqensourz@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).