From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38BAFC282DD for ; Thu, 9 Jan 2020 18:57:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BD22206ED for ; Thu, 9 Jan 2020 18:57:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bAFKLV3Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BD22206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kPrL7beSfwCLBLvz6gXOghhNXZp40uoFtj9N2WFUImQ=; b=bAFKLV3ZbR3I8z 7y1TNol8/q5qv2onT0oAYWQJ9M98da1txH1DvIEzydyXmpiGu7gOvsBPy+roso7XqKMJ3YPqt2RGl r9yibEYHB0H+TtZltICd1NKMAJgIewrwzEmIrpCDaJx5TzjflgAyXhH1nSMUM6aqPYsbJHPL/xWmF A3gi3ait81azGKgx2Uvcr6OCYXs/4KwePiYO8olmg8TJf8BwDb2qCHNdwx3jcKDCN0IlBPjNsa/th n339HFCGG6LF/TZeZ1G8ZrClrSeDLG3xAeruKAA8rz5lPhVKZnoovb9UZLOFinPkouknqHNhFWRDN T8ik2iOgv62Z7ptgdWNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipd03-0008BH-9O; Thu, 09 Jan 2020 18:57:43 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipd00-0008AG-Ov for linux-arm-kernel@lists.infradead.org; Thu, 09 Jan 2020 18:57:42 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 48396B1EC; Thu, 9 Jan 2020 18:57:35 +0000 (UTC) Date: Thu, 09 Jan 2020 19:57:34 +0100 Message-ID: From: Takashi Iwai To: Sriram Periyasamy Subject: Re: [alsa-devel] [PATCH v4] ASoC: Add MediaTek MT6660 Speaker Amp Driver In-Reply-To: <20200109171833.GA2709@sriram-VirtualBox> References: <1578366545-30251-1-git-send-email-richtek.jeff.chang@gmail.com> <20200109171833.GA2709@sriram-VirtualBox> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_105740_953100_71575FDA X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com, Jeff Chang , broonie@kernel.org, matthias.bgg@gmail.com, jeff_chang@richtek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 09 Jan 2020 18:18:36 +0100, Sriram Periyasamy wrote: > > On Tue, Jan 07, 2020 at 11:09:05AM +0800, Jeff Chang wrote: > > From: Jeff Chang > > > > The MT6660 is a boosted BTL class-D amplifier with V/I sensing. > > A built-in DC-DC step-up converter is used to provide efficient > > power for class-D amplifier with multi-level class-G operation. > > The digital audio interface supports I2S, left-justified, > > right-justified, TDM and DSP A/B format for audio in with a data > > out used for chip information like voltage sense and current > > sense, which are able to be monitored via DATAO through proper > > > > diff --git a/sound/soc/codecs/mt6660.c b/sound/soc/codecs/mt6660.c > > new file mode 100644 > > index 0000000..b8fc53b > > --- /dev/null > > +++ b/sound/soc/codecs/mt6660.c > > @@ -0,0 +1,628 @@ > > > + > > +struct codec_reg_val { > > + u32 addr; > > + u32 mask; > > + u32 data; > > +}; > > packed structures could have been better. It depends. Packing may break alignment and the performance may suffer from it. So, in general, __packed is recommended when the size matters (e.g. lots of objects / arrays are created) or it's about ABI that needs the fixed consistent size. thanks, Takashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel