From: tiwai@suse.de (Takashi Iwai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ALSA: hda: fix tegra build
Date: Mon, 26 May 2014 18:31:49 +0200 [thread overview]
Message-ID: <s5h61ksjybu.wl%tiwai@suse.de> (raw)
In-Reply-To: <4769804.MRZYg8zfIB@wuerfel>
At Mon, 26 May 2014 18:14:21 +0200,
Arnd Bergmann wrote:
>
> When CONFIG_PM is disabled, the CONFIG_SND_HDA_POWER_SAVE_DEFAULT symbol
> does not get defined, which causes a build error for the hda-tegra driver:
>
> hda/hda_tegra.c:80:25: error: 'CONFIG_SND_HDA_POWER_SAVE_DEFAULT' undeclared here (not in a function)
> static int power_save = CONFIG_SND_HDA_POWER_SAVE_DEFAULT;
> ^
> /git/arm-soc/sound/pci/hda/hda_tegra.c:235:13: warning: 'hda_tegra_disable_clocks' defined but not used [-Wunused-function]
> static void hda_tegra_disable_clocks(struct hda_tegra *data)
> ^
>
> This works around the problem by not referencing that macro
> when CONFIG_PM is disabled. Instead, we assume that it's disabled
> unconditionally and cannot be enabled at runtime.
>
> Signed-off-by: Dylan Reid <dgreid@chromium.org>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Oh, you cloned me?
Takashi
> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
> index 086fd06..a366ba9 100644
> --- a/sound/pci/hda/hda_tegra.c
> +++ b/sound/pci/hda/hda_tegra.c
> @@ -77,10 +77,14 @@ struct hda_tegra {
> void __iomem *regs;
> };
>
> +#ifdef CONFIG_PM
> static int power_save = CONFIG_SND_HDA_POWER_SAVE_DEFAULT;
> module_param(power_save, bint, 0644);
> MODULE_PARM_DESC(power_save,
> "Automatic power-saving timeout (in seconds, 0 = disable).");
> +#else
> +static int power_save = 0;
> +#endif
>
> /*
> * DMA page allocation ops.
>
next prev parent reply other threads:[~2014-05-26 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 16:14 [PATCH] ALSA: hda: fix tegra build Arnd Bergmann
2014-05-26 16:31 ` Takashi Iwai [this message]
2014-05-26 19:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h61ksjybu.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox