public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: tiwai@suse.de (Takashi Iwai)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ARM: remove VIRT_TO_BUS
Date: Wed, 09 Dec 2015 07:59:20 +0100	[thread overview]
Message-ID: <s5hsi3cyunr.wl-tiwai@suse.de> (raw)
In-Reply-To: <1630488.4B57tj3Z8o@wuerfel>

On Tue, 08 Dec 2015 22:54:45 +0100,
Arnd Bergmann wrote:
> 
> All drivers that are relevant for rpc or footbridge have stopped
> using virt_to_bus a while ago, so we can remove it and avoid some
> harmless randconfig warnings for drivers that we do not care about:
> 
> drivers/atm/zatm.c: In function 'poll_rx':
> drivers/atm/zatm.c:401:18: warning: 'bus_to_virt' is deprecated [-Wdeprecated-declarations]
>    skb = ((struct rx_buffer_head *) bus_to_virt(here[2]))->skb;
> 
> FWIW, the remaining drivers using this are:
> 
> ATM:  firestream, zatm, ambassador, horizon
> ISDN: hisax/netjet
> V4L:  STA2X11, zoran
> Net:  Appletalk LTPC, Tulip DE4x5, Toshiba IrDA
> WAN:  comtrol sv11, cosa, lanmedia, sealevel
> SCSI: DPT_I2O, buslogic
> VME:  CA91C142
> 
> My best guess is that all of the above are so hopelessly obsolete that
> we are best off removing all of them form the kernel, but that can be
> done another time.
> 
> The sound drivers used to rely on virt_to_bus, but don't any more.
> As a lot of architectures don't provide VIRT_TO_BUS any more, removing
> the dependency in sounds/oss/ would make the deprecated drivers appear
> there, which we probably don't want. Instead I'm replacing the
> simple dependency with 'VIRT_TO_BUS || RPC || NETWINDER' so we can
> still build these sound drivers for the platforms that need them,
> but don't change anything on other architectures.

Yeah, agreed.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> No hurry for this one. If we can agree that it's a good idea, we
> can probably do the sound/oss change first, and then do the
> rest for the following merge window. If nobody cares about picking
> up the sound/oss patches, we can also just do it as one patch.

I'm willing to apply sound/oss one now.  Could you split the patch for
that?


thanks,

Takashi

      reply	other threads:[~2015-12-09  6:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 21:54 [RFC] ARM: remove VIRT_TO_BUS Arnd Bergmann
2015-12-09  6:59 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsi3cyunr.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox