From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E810CC433FE for ; Thu, 24 Nov 2022 12:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Message-ID:Date: Mime-Version:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lTL2Af4SJ8mOuVXdoy/UQgLJIoXUGzks5oB5KQFPWRQ=; b=xNPDJscdcka9tQ RKB2AVbssTHWs2SCnYd9XCZx2y7KYBCxuYvo8WfQn+PBj3ByvI7CGVV7e9PJLOsCfhoPk4/ly94vr gHareg7RhpQrfsbB6wTGq4ty0Nu2Iiy1PDl8Id/Q5EBUggTyq78MqUOhR0s6m8y1sWyCopciI3Ain oYd8yh0eDJiIN4cstt7KIKLRqQqSEFJykZabR1s5F/wptPqEuXqEpu1kE0Tyi/wI59+3XhkyQqgh1 7pZ++1OTf1ttepyxL6x96EXrn4bah48wtJyIF9Iyfjv1yOqsn4hlqT7pgUCso95KQc4Y7sOG6qNwC lf9t8m/fFP+7nSBTMBqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyBJq-008L0S-VT; Thu, 24 Nov 2022 12:27:07 +0000 Received: from smtpbgau2.qq.com ([54.206.34.216]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyBJn-008KrJ-O9 for linux-arm-kernel@lists.infradead.org; Thu, 24 Nov 2022 12:27:05 +0000 X-QQ-GoodBg: 2 X-QQ-SSF: 0040000000B00070 X-QQ-FEAT: VErM9xwdPg9fXJXFjioDXrs1P5pGz5d8FgCt2Q+/sjAR2I25JyJLX7g504d5r dNELfK4ICTcRl1gAAQKBkGaa+CJv9VhwKfm6vxE71DaOL8aufz5af26hz/Ovyf9NuGhFDbL WNdrhvyCCXK0MbtfRqNjt8nUgrHylxpqhMQhpHZNGhfJHjDjVEPMVX9oQvqvcSCvizCFozv xR6Uvsnan4FIZAIi7URJt0RL60bHCEhYW80qq103npehQNS5Weytl9PdkvpNO2HEeg3chzj 32fLJUSe7KdGZKtZl73bsjLjPBWNaPANJQi1d79X4D/NN5t9bdC0pkxUViv3+oQVqHP2vQ6 2YHX0EGMbhGKBYbO1i+clnMYnGLe1VmgFwjQ/7BNiH+vjsy/qI= X-QQ-BUSINESS-ORIGIN: 2 X-Originating-IP: 223.72.214.84 X-QQ-STYLE: X-QQ-mid: logic633t1669292784t41384 From: "=?utf-8?B?546L5rSq6L6J?=" To: "=?utf-8?B?U3VkZWVwIEhvbGxh?=" Cc: "=?utf-8?B?Q3Jpc3RpYW4gTWFydXNz?=" , "=?utf-8?B?bGludXgtYXJtLWtlcm5lbA==?=" , "=?utf-8?B?bGludXgta2VybmVs?=" Subject: Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi Mime-Version: 1.0 Date: Thu, 24 Nov 2022 20:26:24 +0800 X-Priority: 3 Message-ID: X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x References: <566DA2F800E4BACA+Y39Ak8xtNJaBqB90@TP-P15V.lan> <20221124111450.mqfpmatba6f7pap6@bogus> In-Reply-To: <20221124111450.mqfpmatba6f7pap6@bogus> X-QQ-ReplyHash: 3043500210 X-QQ-SENDSIZE: 520 Received: from qq.com (unknown [127.0.0.1]) by smtp.qq.com (ESMTP) with SMTP id ; Thu, 24 Nov 2022 20:26:25 +0800 (CST) Feedback-ID: logic:ucas.com.cn:qybglogicsvr:qybglogicsvr4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221124_042704_188416_6AC5F813 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ok! Thanks, Best Regards! Wang Honghui ------------------ Original ------------------From: "Sudeep Holla";Date: Thu, Nov 24, 2022 07:15 PMTo: "Wang Honghui"; Cc: "Cristian Maruss"; "linux-arm-kernel"; "linux-kernel"; Subject: Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi On Thu, Nov 24, 2022 at 05:59:47PM +0800, Wang Honghui wrote:> Rev last modify to support acpi> > Signed-off-by: Wang Honghui > ---> drivers/firmware/arm_scpi.c | 4 ++++> 1 file changed, 4 insertions(+)> > diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c> index e2e90dcc38bd..aca0a9780c12 100644> --- a/drivers/firmware/arm_scpi.c> +++ b/drivers/firmware/arm_scpi.c> @@ -908,7 +908,9 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = {> { }> };> > +#ifdef CONFIG_PHYTIUM_MBOX> extern struct mbox_chan *phytium_mbox_request_channel(struct mbox_client *cl);> +#endifI have already NACK the approach you have taken for SCPI + ACPI. Just forgotto mention SCPI is old and deprecated protocol and SCMI replaced it. Youmuch be using that if possible.Anyways, this kind of #ifdeffery is not allowed in any generic code even ifI agreed with the approach. So please don't change the code in such a way.-- Regards,Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel