Re: [PATCH 1/2] dts/amlogic: Add MagicBox M16S support

[Zhang Ning <zhangn1985@qq.com>]

thank you for review, I will send next version according your advises.

On Sat, Jul 23, 2022 at 10:14:40PM +0200, Martin Blumenstingl wrote:
> Hello,
> 
> great to see this patch!
> 
> On Sat, Jul 23, 2022 at 5:56 PM Zhang Ning <zhangn1985@qq.com> wrote:
> >
> > MagicBox M16S or MagicBox 3Pro is popular Tv box in China.
> >
> > it's q201_v1 according u-boot log.
> > and it's almost same as Q201 reference design.
> >
> > add a simple dts to support this Tv box.
> It would be great if you could add the hardware specs from the
> cover-letter here.
> 
> [...]
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > index 61a6cabb375b..3eac16a4de68 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > @@ -123,6 +123,7 @@ properties:
> >                - khadas,vim2
> >                - kingnovel,r-box-pro
> >                - libretech,aml-s912-pc
> > +              - magicbox,m16s
> >                - minix,neo-u9h
> >                - nexbox,a1
> >                - tronsmart,vega-s96
> The change itself is fine (entries are sorted alphabetically). It
> should go into a separate dt-binding patch though.
> See commit 3f7dbd336f360a ("dt-bindings: arm: amlogic: add Vero 4K+
> bindings") for an example with the correct title and commit message.
> 
> [...]
> > +       gpio-keys-polled {
> > +               compatible = "gpio-keys-polled";
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> #address-cells and #size-cells will be dropped in Linux 5.20 in all
> existing .dts files, see [0]
> Please do the same.
> 
> > +               button-power {
> Button/Key node labels are updated in 5.20 as well (see [1], but
> button-power does match the recommended naming so no change is needed.
> 
> 
> Thank you and best regards,
> Martin
> 
> 
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git/commit/?h=v5.20/arm64-dt&id=4956be9944d1fb23107f27bad8a2cca0fa167443
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git/commit/?h=v5.20/arm64-dt&id=4fd9afd894ebe5831dbd737e6ca7b6de14da7fda

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel