* [PATCH 01/20] pxa3xx_nand: refuse the flash definition get from platform @ 2010-05-06 9:01 Haojian Zhuang 2010-05-07 10:20 ` Daniel Mack 0 siblings, 1 reply; 3+ messages in thread From: Haojian Zhuang @ 2010-05-06 9:01 UTC (permalink / raw) To: linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 01/20] pxa3xx_nand: refuse the flash definition get from platform 2010-05-06 9:01 [PATCH 01/20] pxa3xx_nand: refuse the flash definition get from platform Haojian Zhuang @ 2010-05-07 10:20 ` Daniel Mack 2010-05-07 10:26 ` Haojian Zhuang 0 siblings, 1 reply; 3+ messages in thread From: Daniel Mack @ 2010-05-07 10:20 UTC (permalink / raw) To: linux-arm-kernel Hi, I'd like to test this, but ... On Thu, May 06, 2010 at 05:01:22AM -0400, Haojian Zhuang wrote: > From 135f6369a9c045e58d2cfa445c72bae2bbc645cd Mon Sep 17 00:00:00 2001 > From: Lei Wen <leiwen@marvell.com> > Date: Sat, 20 Mar 2010 19:01:23 +0800 > Subject: [PATCH] pxa3xx_nand: refuse the flash definition get from platform > > For current usage, it is little reason to use a platform defined flash info > for the flash detection. Flash timing through platform should be the same. > And allow multiple platform to define the same flash chip would be a waste. > > Also condense the flash definition way in the c file to simplify adding a > new chip. > > Signed-off-by: Lei Wen <leiwen@marvell.com> > Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com> > --- > arch/arm/plat-pxa/include/plat/pxa3xx_nand.h | 40 ---- > drivers/mtd/nand/Kconfig | 7 - > drivers/mtd/nand/pxa3xx_nand.c | 251 ++++++-------------------- > 3 files changed, 60 insertions(+), 238 deletions(-) > [...] > +static struct pxa3xx_nand_flash __devinitdata builtin_flash_types[] = { > +{ 0x46ec, 32, 512, 16, 16, 4096, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, > +{ 0xdaec, 64, 2048, 8, 8, 2048, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, > +{ 0xd7ec, 128, 4096, 8, 8, 8192, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, > +{ 0xa12c, 64, 2048, 8, 8, 1024, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, > +{ 0xb12c, 64, 2048, 16, 16, 1024, { 10, 25, 15, 25, 15, 30, 25000, > 60, 10, }, }, > +{ 0xdc2c, 64, 2048, 8, 8, 4096, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, > +{ 0xcc2c, 64, 2048, 16, 16, 4096, { 10, 25, 15, 25, 15, 30, 25000, > 60, 10, }, }, That series is line-wrapped. Could you fix this and resend please? Daniel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 01/20] pxa3xx_nand: refuse the flash definition get from platform 2010-05-07 10:20 ` Daniel Mack @ 2010-05-07 10:26 ` Haojian Zhuang 0 siblings, 0 replies; 3+ messages in thread From: Haojian Zhuang @ 2010-05-07 10:26 UTC (permalink / raw) To: linux-arm-kernel On Fri, May 7, 2010 at 6:20 AM, Daniel Mack <daniel@caiaq.de> wrote: > Hi, > > I'd like to test this, but ... > > On Thu, May 06, 2010 at 05:01:22AM -0400, Haojian Zhuang wrote: >> From 135f6369a9c045e58d2cfa445c72bae2bbc645cd Mon Sep 17 00:00:00 2001 >> From: Lei Wen <leiwen@marvell.com> >> Date: Sat, 20 Mar 2010 19:01:23 +0800 >> Subject: [PATCH] pxa3xx_nand: refuse the flash definition get from platform >> >> For current usage, it is little reason to use a platform defined flash info >> for the flash detection. Flash timing through platform should be the same. >> And allow multiple platform to define the same flash chip would be a waste. >> >> Also condense the flash definition way in the c file to simplify adding a >> new chip. >> >> Signed-off-by: Lei Wen <leiwen@marvell.com> >> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com> >> --- >> ?arch/arm/plat-pxa/include/plat/pxa3xx_nand.h | ? 40 ---- >> ?drivers/mtd/nand/Kconfig ? ? ? ? ? ? ? ? ? ? | ? ?7 - >> ?drivers/mtd/nand/pxa3xx_nand.c ? ? ? ? ? ? ? | ?251 ++++++-------------------- >> ?3 files changed, 60 insertions(+), 238 deletions(-) >> > > [...] > >> +static struct pxa3xx_nand_flash __devinitdata builtin_flash_types[] = { >> +{ 0x46ec, 32, 512, 16, 16, 4096, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, >> +{ 0xdaec, 64, 2048, 8, 8, 2048, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, >> +{ 0xd7ec, 128, 4096, 8, 8, 8192, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, >> +{ 0xa12c, 64, 2048, 8, 8, 1024, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, >> +{ 0xb12c, 64, 2048, 16, 16, 1024, { 10, 25, 15, 25, 15, 30, 25000, >> 60, 10, }, }, >> +{ 0xdc2c, 64, 2048, 8, 8, 4096, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, >> +{ 0xcc2c, 64, 2048, 16, 16, 4096, { 10, 25, 15, 25, 15, 30, 25000, >> 60, 10, }, }, > > That series is line-wrapped. Could you fix this and resend please? > > Daniel > > Now I attached these patches. Try these. Thanks Haojian -------------- next part -------------- A non-text attachment was scrubbed... Name: pxa3xx_nand.tgz Type: application/x-gzip Size: 43457 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100507/fdd69adf/attachment-0001.tgz> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-07 10:26 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-05-06 9:01 [PATCH 01/20] pxa3xx_nand: refuse the flash definition get from platform Haojian Zhuang 2010-05-07 10:20 ` Daniel Mack 2010-05-07 10:26 ` Haojian Zhuang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).