From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa/vpac270: PXAUDC init fix
Date: Tue, 4 May 2010 22:44:40 +0800 [thread overview]
Message-ID: <v2lf17812d71005040744r7893368cxa31255a2fc6afb@mail.gmail.com> (raw)
In-Reply-To: <1272773425-13454-1-git-send-email-marek.vasut@gmail.com>
On Sun, May 2, 2010 at 12:10 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> This patch removes write to UP2OCR[DMSTATE] (ex-UP2OCR_DPPUBE) which is invalid
> on PXA270C5 and later.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Applied.
> ---
> ?arch/arm/mach-pxa/vpac270.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/vpac270.c b/arch/arm/mach-pxa/vpac270.c
> index 8da22d4..9884fa9 100644
> --- a/arch/arm/mach-pxa/vpac270.c
> +++ b/arch/arm/mach-pxa/vpac270.c
> @@ -359,9 +359,9 @@ static struct platform_device vpac270_gpio_vbus = {
> ?static void vpac270_udc_command(int cmd)
> ?{
> ? ? ? ?if (cmd == PXA2XX_UDC_CMD_CONNECT)
> - ? ? ? ? ? ? ? UP2OCR |= UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE;
> + ? ? ? ? ? ? ? UP2OCR = UP2OCR_HXOE | UP2OCR_DPPUE;
> ? ? ? ?else if (cmd == PXA2XX_UDC_CMD_DISCONNECT)
> - ? ? ? ? ? ? ? UP2OCR &= ~(UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE);
> + ? ? ? ? ? ? ? UP2OCR = UP2OCR_HXOE;
> ?}
>
> ?static struct pxa2xx_udc_mach_info vpac270_udc_info __initdata = {
> --
> 1.7.0
>
>
prev parent reply other threads:[~2010-05-04 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 4:10 [PATCH] pxa/vpac270: PXAUDC init fix Marek Vasut
2010-05-04 14:44 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v2lf17812d71005040744r7893368cxa31255a2fc6afb@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).