From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Arm nomadik : Vendor tool compatibility
Date: Thu, 1 Apr 2010 01:34:24 +0200 [thread overview]
Message-ID: <x2y63386a3d1003311634l71486234n95f60e506b776948@mail.gmail.com> (raw)
In-Reply-To: <577FAEEB8540FB4F9C91B6BB262576755905DC@XVS-DCFR-22.europe.corp.altran.com>
2010/3/31 Lemetayer Jean Marie <jeanmarie.lemetayer@altran.com>:
> +#ifdef CONFIG_VENDOR_TOOL_COMPATIBILITY
> +static struct nand_ecclayout nomadik_ecc_layout = {
> +?????? .eccbytes = 3 * 4,
> +?????? .eccpos = {
> +?????? ??????? 0x28, 0x29, 0x2A,
> +?????? ??????? 0x2B, 0x2C, 0x2D,
> +?????? ??????? 0x2E, 0x2F, 0x30,
> +?????? ??????? 0x31, 0x32, 0x33},
> +?????? .oobfree = {{0x02, 0x26}, {0x34, 0x0C} },
> +};
> +#else
> ?static struct nand_ecclayout nomadik_ecc_layout = {
> ??????? .eccbytes = 3 * 4,
> ??????? .eccpos = { /* each subpage has 16 bytes: pos 2,3,4 hosts ECC */
> @@ -54,6 +65,7 @@ static struct nand_ecclayout nomadik_ecc_layout = {
> ??????? /* let's keep bytes 5,6,7 for us, just in case we change ECC algo */
> ??????? .oobfree = { {0x08, 0x08}, {0x18, 0x08}, {0x28, 0x08}, {0x38, 0x08}
> },
> ?};
> +#endif
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
I don't think any of this layout belongs in the driver itself frankly speaking,
I am facing the need to use this in U300 and we use yet *another*
ECC layout with the FSMC, so we have to add yet another #ifdef.
However I can fix that up with a patch on top of this one after it's
queued.
Yours,
Linus Walleij
next prev parent reply other threads:[~2010-03-31 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AcrQ47RPeBz4nhRMR9ORyzmB2isxaQ==>
2010-03-31 15:06 ` [PATCH] Arm nomadik : Vendor tool compatibility Lemetayer Jean Marie
2010-03-31 23:34 ` Linus Walleij [this message]
2010-04-12 19:29 ` Jean-Michel Hautbois
2010-04-13 0:26 ` Linus Walleij
2010-03-31 13:19 Jean-Marie Lemetayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x2y63386a3d1003311634l71486234n95f60e506b776948@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).