From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1F75C761A6 for ; Thu, 6 Apr 2023 14:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AqtcpC7VVMs+Wswfm2d/7pQzlZJN+C0Xom7Dk3YGP5g=; b=DPwi9PhRI+zLXN JORXev/u2qv41r/dS4ROX14q9iXDLVWi/rPs3toVQcUt2jv2cH9i+4m8oPiKUGAUC8PVie8nO4dYG crZtbrYFePzq95V2gStpDXsxe2GExYgGA1dL/9lM+rNY4W4+ql6On8VBD6U6vMnFNU2Fj5pIsNCud lbzCNW3970Ik/NKXSLs3qR9vw6JBNpwEqhseiBtmSxv+dZ8iv/bLyE4F3kZi1r8ZGJdKUFKf3035s MZGdMpjSAg3oGNVc0Pr0Gctg+pp5nEjfSbmicdVbc3ItJW9E5wLRG7QpwaeyJxVOc0WJ6cd17j3tu Ai/9H89K7YzbiBgfDDRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkQLQ-007Xan-1V; Thu, 06 Apr 2023 14:12:08 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkQLN-007XYV-24 for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2023 14:12:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680790322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oy2QomrGUBDfWG7234e6lYS9Z4zzgLJXtJtCEsgjhmY=; b=KqgI7fCZrOhz6x0LHRTRqHaocXnhl+PSCDrkvdigKJnJuMoeoC/udCKrXiz6U5FcgFhrOL bPvnH6bhKqVWYUBlphFcOYxnIxwNos8mjcYl629YJWNlCkXWxAjzaVzotD3U1OrJtrFyQq m3gB2TuSseY0CJ5Ayl7yEmzosR20WO8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-L5NFP6yBPyy8RU3NSzlydg-1; Thu, 06 Apr 2023 10:12:00 -0400 X-MC-Unique: L5NFP6yBPyy8RU3NSzlydg-1 Received: by mail-qv1-f71.google.com with SMTP id a10-20020a0ccdca000000b005d70160fbb0so17881950qvn.21 for ; Thu, 06 Apr 2023 07:12:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680790319; x=1683382319; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oy2QomrGUBDfWG7234e6lYS9Z4zzgLJXtJtCEsgjhmY=; b=XG0E31YS+wIdT0LhVXCd83J1xBAkLE0XumIfajTgzYFSSp4o8oBpZgD1U60M1xVgfa 4Z35/RjWW2WxfGMvRcxz19gk3r+Gto0eip2cHoc9ss5lg302H5pFKx0ISViOYjxQ02oT 2omU/5WNKDPv7ODuQzzJr3EH2djNL4jv7/UDOlRAQeTXMV2m8Y9gPPTuySZ5WWYILA+U vJHYG7A+2UG8lyyo7e15l9iEUaoL0El17/UTNUe86mCsyX6cKAtfTcPT3fflDEL0klnq ozKSgB5Z2BRa2DhPxt7XiSoiEAqJys8/QFv5La0n6LxMyndR+2rBS+cQ1YTW0eyEehNK xa/g== X-Gm-Message-State: AAQBX9caBxmsqeFtHQ10WyF+VAcdOGj0UPboSWQ44ZHa/+C53TsM56tM Gn/XqUL60EBEO28XIGCgoj6An4BBBI80bKUiRZ7m8/Rc3C6X5B0R1cKUnf4r9+dllcmNkOA2fZ2 B4RmtnvjbQ1lkf4CEbyhRtOF8vDBMx1KOaU0= X-Received: by 2002:a05:6214:c21:b0:5a2:e3e4:59b0 with SMTP id a1-20020a0562140c2100b005a2e3e459b0mr4151638qvd.44.1680790319551; Thu, 06 Apr 2023 07:11:59 -0700 (PDT) X-Google-Smtp-Source: AKy350YdFg9Rpod34ylmYUyAnCfxfiKdtnShPJSS+THNG9On45kotrwTmF6ARLq441OR3LQJbmn9Kg== X-Received: by 2002:a05:6214:c21:b0:5a2:e3e4:59b0 with SMTP id a1-20020a0562140c2100b005a2e3e459b0mr4151612qvd.44.1680790319253; Thu, 06 Apr 2023 07:11:59 -0700 (PDT) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id d11-20020a0cf6cb000000b005dd8b9345f4sm514523qvo.140.2023.04.06.07.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 07:11:58 -0700 (PDT) From: Valentin Schneider To: Peter Zijlstra Cc: Frederic Weisbecker , Yair Podemsky , linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mtosatti@redhat.com, dhildenb@redhat.com, alougovs@redhat.com Subject: Re: [PATCH 3/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to CPUs in kernel mode In-Reply-To: <20230406133805.GO386572@hirez.programming.kicks-ass.net> References: <20230404134224.137038-1-ypodemsk@redhat.com> <20230404134224.137038-4-ypodemsk@redhat.com> <20230405114148.GA351571@hirez.programming.kicks-ass.net> <20230406133805.GO386572@hirez.programming.kicks-ass.net> Date: Thu, 06 Apr 2023 15:11:52 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_071205_771609_77B49030 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/04/23 15:38, Peter Zijlstra wrote: > On Wed, Apr 05, 2023 at 01:45:02PM +0100, Valentin Schneider wrote: >> >> I've been hacking on something like this (CSD deferral for NOHZ-full), >> and unfortunately this uses the CPU-local cfd_data storage thing, which >> means any further smp_call_function() from the same CPU to the same >> destination will spin on csd_lock_wait(), waiting for the target CPU to >> come out of userspace and flush the queue - and we've just spent extra >> effort into *not* disturbing it, so that'll take a while :( > > I'm not sure I buy into deferring stuff.. a NOHZ_FULL cpu might 'never' > come back. Queueing data just in case it does seems wasteful. Putting those callbacks straight into the bin would make my life much easier! Unfortunately, even if they really should, I don't believe all of the things being crammed onto NOHZ_FULL CPUs have the same definition of 'never' as we do :/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel